<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/23498">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gmm_fsm: Expect E_GMM_COMMON_PROC_INIT_REQ when in ST_GMM_COMMON_PROC_INIT<br><br>Due to whatever errors, the MS may re-init the Common Procedure by<br>retransmitting a GPRS Attach Request while we are for instance aiting<br>for Identity to be resolved.<br><br>See this log:<br>MM(---/ffffffff) -> GMM ATTACH REQUEST MI(3903513414) type="GPRS attach"<br>GMM(gmm_fsm)[0x8136110]{Deregistered}: Allocated<br>GMM_ATTACH_REQ_FSM(gb_gmm_req)[0x81383c0]{Init}: Allocated<br>MM_STATE_Gb[0x8138ac0]{Idle}: Allocated<br>MM_STATE_Iu[0x8138bb0]{Detached}: Allocated<br>GMM(gmm_fsm)[0x8136110]{Deregistered}: Received Event E_GMM_COMMON_PROC_INIT_REQ<br>GMM(gmm_fsm)[0x8136110]{Deregistered}: state_chg to CommonProcedureInitiated<br>GMM_ATTACH_REQ_FSM(gb_gmm_req)[0x81383c0]{Init}: Received Event E_ATTACH_REQ_RECV<br>GMM_ATTACH_REQ_FSM(gb_gmm_req)[0x81383c0]{Init}: state_chg to CheckIdentity<br>MM(/fba673a2) <- GPRS IDENTITY REQUEST: mi_type=IMEI<br>UE(0x2){001-01-10422-99} Received GSM 04.08 message type 0x16, but no MM context available<br>GMM_ATTACH_REQ_FSM(gb_gmm_req)[0x81383c0]{CheckIdentity}: Timeout of T3370<br>MM(/fba673a2) <- GPRS IDENTITY REQUEST: mi_type=IMEI<br>[Failure to handle GSM48_MT_GMM_ID_RESP and subsequent retransmission of GPRS IDENTITY REQUEST happens a couple times here]<br>MM(---/ffffffff) -> GMM ATTACH REQUEST MI(3903513414) type="GPRS attach"<br>GMM(gmm_fsm)[0x8136110]{CommonProcedureInitiated}: Received Event E_GMM_COMMON_PROC_INIT_REQ<br>GMM(gmm_fsm)[0x8136110]{CommonProcedureInitiated}: Event E_GMM_COMMON_PROC_INIT_REQ not permitted<br>GMM_ATTACH_REQ_FSM(gb_gmm_req)[0x81383c0]{CheckIdentity}: Received Event E_ATTACH_REQ_RECV<br>[Here IDENTITY REQUEST is sent again, and this time MS answers ID RESPONSE back and goes forward]<br><br>Related: SYS#5389<br>Change-Id: I93d7d6bc694c84223a11d075d24c234b82b73389<br>---<br>M src/sgsn/gprs_gmm_fsm.c<br>1 file changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/98/23498/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/gprs_gmm_fsm.c b/src/sgsn/gprs_gmm_fsm.c</span><br><span>index 886726c..caec586 100644</span><br><span>--- a/src/sgsn/gprs_gmm_fsm.c</span><br><span>+++ b/src/sgsn/gprs_gmm_fsm.c</span><br><span>@@ -57,6 +57,10 @@</span><br><span> static void st_gmm_common_proc_init(struct osmo_fsm_inst *fi, uint32_t event, void *data)</span><br><span> {</span><br><span>       switch(event) {</span><br><span style="color: hsl(120, 100%, 40%);">+       case E_GMM_COMMON_PROC_INIT_REQ:</span><br><span style="color: hsl(120, 100%, 40%);">+              /* MS may retransmit GPRS Attach Request if for some reason</span><br><span style="color: hsl(120, 100%, 40%);">+            * CommonProcedure didn't go forward correctly */</span><br><span style="color: hsl(120, 100%, 40%);">+         break;</span><br><span>       /* TODO: events not used</span><br><span>     case E_GMM_LOWER_LAYER_FAILED:</span><br><span>       case E_GMM_COMMON_PROC_FAILED:</span><br><span>@@ -126,7 +130,8 @@</span><br><span>                         /* X(E_GMM_LOWER_LAYER_FAILED) | */</span><br><span>                  /* X(E_GMM_COMMON_PROC_FAILED) | */</span><br><span>                  X(E_GMM_COMMON_PROC_SUCCESS) |</span><br><span style="color: hsl(0, 100%, 40%);">-                  X(E_GMM_ATTACH_SUCCESS),</span><br><span style="color: hsl(120, 100%, 40%);">+                      X(E_GMM_ATTACH_SUCCESS) |</span><br><span style="color: hsl(120, 100%, 40%);">+                     X(E_GMM_COMMON_PROC_INIT_REQ),</span><br><span>               .out_state_mask =</span><br><span>                    X(ST_GMM_DEREGISTERED) |</span><br><span>                     X(ST_GMM_REGISTERED_NORMAL),</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/23498">change 23498</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/23498"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I93d7d6bc694c84223a11d075d24c234b82b73389 </div>
<div style="display:none"> Gerrit-Change-Number: 23498 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>