<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23491">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch_ulc: Create helper API pdch_ulc_release_node<br><br>Change-Id: I6362ad7382c2b73e6fedb11182964be96e5c8d35<br>---<br>M src/pdch_ul_controller.c<br>M src/pdch_ul_controller.h<br>2 files changed, 9 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/91/23491/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch_ul_controller.c b/src/pdch_ul_controller.c</span><br><span>index cd705d0..f7b2335 100644</span><br><span>--- a/src/pdch_ul_controller.c</span><br><span>+++ b/src/pdch_ul_controller.c</span><br><span>@@ -183,13 +183,18 @@</span><br><span>      return pdch_ulc_add_node(ulc, item);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void pdch_ulc_release_node(struct pdch_ulc *ulc, struct pdch_ulc_node *item)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+        rb_erase(&item->node, &ulc->tree_root);</span><br><span style="color: hsl(120, 100%, 40%);">+ talloc_free(item);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> int pdch_ulc_release_fn(struct pdch_ulc *ulc, uint32_t fn)</span><br><span> {</span><br><span>   struct pdch_ulc_node *item = pdch_ulc_get_node(ulc, fn);</span><br><span>     if (!item)</span><br><span>           return -ENOKEY;</span><br><span style="color: hsl(0, 100%, 40%);">- rb_erase(&item->node, &ulc->tree_root);</span><br><span style="color: hsl(0, 100%, 40%);">-   talloc_free(item);</span><br><span style="color: hsl(120, 100%, 40%);">+    pdch_ulc_release_node(ulc, item);</span><br><span>    return 0;</span><br><span> }</span><br><span> </span><br><span>@@ -222,8 +227,7 @@</span><br><span>                      * search from start (to avoid traverse continue from</span><br><span>                         * no-more existant node */</span><br><span>                  tree_modified = true;</span><br><span style="color: hsl(0, 100%, 40%);">-                   rb_erase(&item->node, &ulc->tree_root);</span><br><span style="color: hsl(0, 100%, 40%);">-                   talloc_free(item);</span><br><span style="color: hsl(120, 100%, 40%);">+                    pdch_ulc_release_node(ulc, item);</span><br><span>                    break;</span><br><span>               }</span><br><span>    } while (tree_modified);</span><br><span>diff --git a/src/pdch_ul_controller.h b/src/pdch_ul_controller.h</span><br><span>index eb93143..731cbe1 100644</span><br><span>--- a/src/pdch_ul_controller.h</span><br><span>+++ b/src/pdch_ul_controller.h</span><br><span>@@ -77,8 +77,8 @@</span><br><span> struct gprs_rlcmac_sba *pdch_ulc_get_sba(struct pdch_ulc *ulc, uint32_t fn);</span><br><span> struct gprs_rlcmac_tbf *pdch_ulc_get_tbf_poll(struct pdch_ulc *ulc, uint32_t fn);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void pdch_ulc_release_node(struct pdch_ulc *ulc, struct pdch_ulc_node *item);</span><br><span> void pdch_ulc_release_tbf(struct pdch_ulc *ulc, const struct gprs_rlcmac_tbf *tbf);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> int pdch_ulc_release_fn(struct pdch_ulc *ulc, uint32_t fn);</span><br><span> </span><br><span> void pdch_ulc_expire_fn(struct pdch_ulc *ulc, uint32_t fn);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/23491">change 23491</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/23491"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6362ad7382c2b73e6fedb11182964be96e5c8d35 </div>
<div style="display:none"> Gerrit-Change-Number: 23491 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>