<p>neels <strong>uploaded patch set #3</strong> to this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix/refactor neighbor config<br><br>The neighbor configuration storage is fundamentally broken: it requires<br>all local cells to be configured before being able to list them as<br>neighbors of each other. Upon config write-back, the neighbor config<br>however is placed back inline with the other config, and hence a<br>written-out neighbor config no longer works on program restart.<br><br>The cause of this problem is that the config is stored as explicit<br>pointers between local cells (struct gsm_bts), which of course requires<br>the pointer to exist before being able to reference it.<br><br>Instead, store the actual configuration that the user entered as-is,<br>without pointers or references to objects that need to be ready. Resolve<br>the neighbors every time a neighbor is needed.<br><br>Hence the user may enter any config at any place in the config file,<br>even non-working config (like a BTS number that doesn't exist), and the<br>relation to actual local or remote neighbor cells is made at runtime.<br><br>Abort program startup if the initial neighbor configuration contains<br>errors.<br><br>Related: OS#5018<br>Change-Id: I9ed992f8bfff888b3933733c0576f92d50f2625b<br>---<br>M include/osmocom/bsc/bts.h<br>M include/osmocom/bsc/gsm_data.h<br>M include/osmocom/bsc/handover.h<br>M include/osmocom/bsc/neighbor_ident.h<br>M src/osmo-bsc/bsc_init.c<br>M src/osmo-bsc/bsc_vty.c<br>M src/osmo-bsc/bts.c<br>M src/osmo-bsc/handover_decision.c<br>M src/osmo-bsc/handover_decision_2.c<br>M src/osmo-bsc/handover_fsm.c<br>M src/osmo-bsc/handover_logic.c<br>M src/osmo-bsc/neighbor_ident.c<br>M src/osmo-bsc/neighbor_ident_vty.c<br>M src/osmo-bsc/osmo_bsc_main.c<br>M src/osmo-bsc/system_information.c<br>M tests/bsc/bsc_test.c<br>M tests/ctrl/osmo-bsc-neigh-test.cfg<br>M tests/gsm0408/gsm0408_test.c<br>M tests/neighbor_ident.vty<br>19 files changed, 921 insertions(+), 1,024 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/23360/3</pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360">change 23360</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23360"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9ed992f8bfff888b3933733c0576f92d50f2625b </div>
<div style="display:none"> Gerrit-Change-Number: 23360 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newpatchset </div>