<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23479">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_sns: Compute local endpoints before using them<br><br>This fixes some bug introduced in Change-Id I1638f04ba45fef3ba0b237948dff6022267141fb<br><br>Related: OS#3373<br><br>Change-Id: Ic0873e63f1f046b674c7898480ff070a18a7abc7<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/23479/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 51e4e9e..7268809 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -2179,10 +2179,12 @@</span><br><span>               /* decide if we go for IPv4 or IPv6 */</span><br><span>               if (gss->num_max_ip6_remote && ns2_sns_count_num_local_ep(fi, IPv6)) {</span><br><span>                    gss->ip = IPv6;</span><br><span style="color: hsl(120, 100%, 40%);">+                    ns2_sns_compute_local_ep_from_binds(fi);</span><br><span>                     num_local_eps = gss->num_ip6_local;</span><br><span>                       num_remote_eps = gss->num_max_ip6_remote;</span><br><span>                 } else if (gss->num_max_ip4_remote && ns2_sns_count_num_local_ep(fi, IPv4)) {</span><br><span>                     gss->ip = IPv4;</span><br><span style="color: hsl(120, 100%, 40%);">+                    ns2_sns_compute_local_ep_from_binds(fi);</span><br><span>                     num_local_eps = gss->num_ip4_local;</span><br><span>                       num_remote_eps = gss->num_max_ip4_remote;</span><br><span>                 } else {</span><br><span>@@ -2193,7 +2195,6 @@</span><br><span>                     ns2_tx_sns_size_ack(gss->sns_nsvc, &cause);</span><br><span>                   break;</span><br><span>               }</span><br><span style="color: hsl(0, 100%, 40%);">-               ns2_sns_compute_local_ep_from_binds(fi);</span><br><span>             /* ensure number of NS-VCs is sufficient for full mesh */</span><br><span>            gss->num_max_nsvcs = tlvp_val16be(tp, NS_IE_MAX_NR_NSVC);</span><br><span>                 if (gss->num_max_nsvcs < num_remote_eps * num_local_eps) {</span><br><span>@@ -2224,6 +2225,7 @@</span><br><span>                                     gprs_ns2_free_nsvc(nsvc);</span><br><span>                            }</span><br><span>                    }</span><br><span style="color: hsl(120, 100%, 40%);">+                     ns2_sns_compute_local_ep_from_binds(fi);</span><br><span>             }</span><br><span>            /* send SIZE_ACK */</span><br><span>          ns2_tx_sns_size_ack(gss->sns_nsvc, NULL);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23479">change 23479</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23479"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic0873e63f1f046b674c7898480ff070a18a7abc7 </div>
<div style="display:none"> Gerrit-Change-Number: 23479 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>