<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23408">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_vty: Allow creating NSE in sgsn-role<br><br>Change-Id: I694fa6c80d04d13cb1afaae93a9ae43b6dfd2207<br>Related: OS#3373<br>---<br>M src/gb/gprs_ns2_vty.c<br>M tests/gb/gprs_ns2_vty.vty<br>2 files changed, 10 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_vty.c b/src/gb/gprs_ns2_vty.c</span><br><span>index a769ad1..42ab2b2 100644</span><br><span>--- a/src/gb/gprs_ns2_vty.c</span><br><span>+++ b/src/gb/gprs_ns2_vty.c</span><br><span>@@ -270,15 +270,19 @@</span><br><span> }</span><br><span> </span><br><span> DEFUN(cfg_ns_nsei, cfg_ns_nsei_cmd,</span><br><span style="color: hsl(0, 100%, 40%);">-      "nse <0-65535>",</span><br><span style="color: hsl(120, 100%, 40%);">+      "nse <0-65535> [ip-sns-role-sgsn]",</span><br><span>       "Persistent NS Entity\n"</span><br><span>       "NS Entity ID (NSEI)\n"</span><br><span style="color: hsl(120, 100%, 40%);">+      "Create NSE in SGSN role (default: BSS)\n"</span><br><span>       )</span><br><span> {</span><br><span>  struct gprs_ns2_nse *nse;</span><br><span>    struct vty_nse *vnse;</span><br><span>        uint16_t nsei = atoi(argv[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+        bool sgsn_role = false;</span><br><span>      bool free_vnse = false;</span><br><span style="color: hsl(120, 100%, 40%);">+       if (argc > 1 && !strcmp(argv[1], "ip-sns-role-sgsn"))</span><br><span style="color: hsl(120, 100%, 40%);">+            sgsn_role = true;</span><br><span> </span><br><span>        vnse = vty_nse_by_nsei(nsei);</span><br><span>        if (!vnse) {</span><br><span>@@ -292,7 +296,8 @@</span><br><span> </span><br><span>       nse = gprs_ns2_nse_by_nsei(vty_nsi, nsei);</span><br><span>   if (!nse) {</span><br><span style="color: hsl(0, 100%, 40%);">-             nse = gprs_ns2_create_nse(vty_nsi, nsei, GPRS_NS2_LL_UNDEF, GPRS_NS2_DIALECT_UNDEF);</span><br><span style="color: hsl(120, 100%, 40%);">+          nse = gprs_ns2_create_nse2(vty_nsi, nsei, GPRS_NS2_LL_UNDEF, GPRS_NS2_DIALECT_UNDEF,</span><br><span style="color: hsl(120, 100%, 40%);">+                                     sgsn_role);</span><br><span>               if (!nse) {</span><br><span>                  vty_out(vty, "Failed to create NSE!%s", VTY_NEWLINE);</span><br><span>                      goto err;</span><br><span>@@ -526,7 +531,8 @@</span><br><span> </span><br><span>  OSMO_ASSERT(vnse);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  vty_out(vty, " nse %u%s", nse->nsei, VTY_NEWLINE);</span><br><span style="color: hsl(120, 100%, 40%);">+       vty_out(vty, " nse %u%s%s", nse->nsei,</span><br><span style="color: hsl(120, 100%, 40%);">+           nse->ip_sns_role_sgsn ? " ip-sns-role-sgsn" : "", VTY_NEWLINE);</span><br><span>       switch (nse->dialect) {</span><br><span>   case GPRS_NS2_DIALECT_SNS:</span><br><span>           ns2_sns_write_vty(vty, nse);</span><br><span>diff --git a/tests/gb/gprs_ns2_vty.vty b/tests/gb/gprs_ns2_vty.vty</span><br><span>index f0253fc..f344bf3 100644</span><br><span>--- a/tests/gb/gprs_ns2_vty.vty</span><br><span>+++ b/tests/gb/gprs_ns2_vty.vty</span><br><span>@@ -18,7 +18,7 @@</span><br><span> OsmoNSdummy(config-ns)# list</span><br><span> ...</span><br><span>   timer (tns-block|tns-block-retries|tns-reset|tns-reset-retries|tns-test|tns-alive|tns-alive-retries|tsns-prov|tsns-size-retries|tsns-config-retries) <0-65535></span><br><span style="color: hsl(0, 100%, 40%);">-  nse <0-65535></span><br><span style="color: hsl(120, 100%, 40%);">+  nse <0-65535> [ip-sns-role-sgsn]</span><br><span>   no nse <0-65535></span><br><span>   bind (fr|udp) ID</span><br><span>   no bind ID</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23408">change 23408</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23408"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I694fa6c80d04d13cb1afaae93a9ae43b6dfd2207 </div>
<div style="display:none"> Gerrit-Change-Number: 23408 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>