<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/23475">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">cards: don't use pyTLV<br><br>To generate the the ims-hdomain, impi and impu TLV string it is not<br>necessary to use pyTLV, a simple format string works just as well<br>but without creating a dependency pyTLV.<br><br>Change-Id: I17009223f55a9efadfde419c5514702496072cb9<br>Related: OS#4963<br>---<br>M pySim/cards.py<br>1 file changed, 3 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/23475/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index c640591..4d02ac6 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -27,7 +27,6 @@</span><br><span> from pySim.ts_31_103 import EF_ISIM_ADF_map</span><br><span> from pySim.utils import *</span><br><span> from smartcard.util import toBytes</span><br><span style="color: hsl(0, 100%, 40%);">-from pytlv.TLV import *</span><br><span> </span><br><span> class Card(object):</span><br><span> </span><br><span>@@ -367,8 +366,7 @@</span><br><span>                  hex_str = s2h('ims.' + plmn_str + '.3gppnetwork.org')</span><br><span> </span><br><span>            # Build TLV</span><br><span style="color: hsl(0, 100%, 40%);">-             tlv = TLV(['80'])</span><br><span style="color: hsl(0, 100%, 40%);">-               content = tlv.build({'80': hex_str})</span><br><span style="color: hsl(120, 100%, 40%);">+          content = ("80%02x%s" % (len(hex_str)//2, hex_str)).upper()</span><br><span> </span><br><span>            bin_size_bytes = self._scc.binary_size(EF_ISIM_ADF_map['DOMAIN'])</span><br><span>            data, sw = self._scc.update_binary(EF_ISIM_ADF_map['DOMAIN'], rpad(content, bin_size_bytes*2))</span><br><span>@@ -389,8 +387,7 @@</span><br><span>                 if impi:</span><br><span>                     hex_str = s2h(impi)</span><br><span>          # Build TLV</span><br><span style="color: hsl(0, 100%, 40%);">-             tlv = TLV(['80'])</span><br><span style="color: hsl(0, 100%, 40%);">-               content = tlv.build({'80': hex_str})</span><br><span style="color: hsl(120, 100%, 40%);">+          content = ("80%02x%s" % (len(hex_str)//2, hex_str)).upper()</span><br><span> </span><br><span>            bin_size_bytes = self._scc.binary_size(EF_ISIM_ADF_map['IMPI'])</span><br><span>              data, sw = self._scc.update_binary(EF_ISIM_ADF_map['IMPI'], rpad(content, bin_size_bytes*2))</span><br><span>@@ -415,8 +412,7 @@</span><br><span>           if impu:</span><br><span>                     hex_str = s2h(impu)</span><br><span>          # Build TLV</span><br><span style="color: hsl(0, 100%, 40%);">-             tlv = TLV(['80'])</span><br><span style="color: hsl(0, 100%, 40%);">-               content = tlv.build({'80': hex_str})</span><br><span style="color: hsl(120, 100%, 40%);">+          content = ("80%02x%s" % (len(hex_str)//2, hex_str)).upper()</span><br><span> </span><br><span>            rec_size_bytes = self._scc.record_size(EF_ISIM_ADF_map['IMPU'])</span><br><span>              impu_tlv = rpad(content, rec_size_bytes*2)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23475">change 23475</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23475"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I17009223f55a9efadfde419c5514702496072cb9 </div>
<div style="display:none"> Gerrit-Change-Number: 23475 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>