<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23464">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BTS_Tests: cosmetic: s/f_init_pcu_test/f_init_with_pcuif/<br><br>Change-Id: Ic95c46426ed3ac9ead645037059190fead181b31<br>---<br>M bts/BTS_Tests.ttcn<br>1 file changed, 20 insertions(+), 20 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/64/23464/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn</span><br><span>index 1dad6c1..0ad55ce 100644</span><br><span>--- a/bts/BTS_Tests.ttcn</span><br><span>+++ b/bts/BTS_Tests.ttcn</span><br><span>@@ -4624,42 +4624,42 @@</span><br><span>    }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-friend function f_init_pcu_test() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_init_with_pcuif() runs on test_CT {</span><br><span>         f_init();</span><br><span>    PCU.send(t_SD_PCUIF(g_pcu_conn_id, ts_PCUIF_TXT_IND(0, PCU_VERSION, testcasename())));</span><br><span> }</span><br><span> </span><br><span> /* PDCH activation via PCU socket; check for presence of RTS.req */</span><br><span> testcase TC_pcu_act_req() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-   f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     f_TC_pcu_act_req(0, 0, 7, true);</span><br><span> }</span><br><span> </span><br><span> /* PDCH activation via PCU socket on non-PDCU timeslot */</span><br><span> testcase TC_pcu_act_req_wrong_ts() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-  f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     f_TC_pcu_act_req(0, 0, 1, false);</span><br><span> }</span><br><span> </span><br><span> /* PDCH activation via PCU socket on wrong BTS */</span><br><span> testcase TC_pcu_act_req_wrong_bts() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-        f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     f_TC_pcu_act_req(23, 0, 7, false);</span><br><span> }</span><br><span> </span><br><span> /* PDCH activation via PCU socket on wrong TRX */</span><br><span> testcase TC_pcu_act_req_wrong_trx() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-       f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     f_TC_pcu_act_req(0, 23, 7, false);</span><br><span> }</span><br><span> </span><br><span> /* PDCH deactivation via PCU socket; check for absence of RTS.req */</span><br><span> testcase TC_pcu_deact_req() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-    f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     /* Activate PDCH */</span><br><span>  f_TC_pcu_act_req(0, 0, 7, true);</span><br><span>@@ -4670,7 +4670,7 @@</span><br><span> </span><br><span> /* Attempt to deactivate a PDCH on a non-PDCH timeslot */</span><br><span> testcase TC_pcu_deact_req_wrong_ts() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-     f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     f_TC_pcu_deact_req(0, 0, 1);</span><br><span> }</span><br><span>@@ -4679,7 +4679,7 @@</span><br><span> function f_TC_pcu_ver_siXX(octetstring si, RSL_IE_SysinfoType rsl_si_type) runs on test_CT {</span><br><span>    var PCUIF_send_data sd;</span><br><span>      timer T:= 3.0;</span><br><span style="color: hsl(0, 100%, 40%);">-  f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     /* Set SI13 via RSL */</span><br><span>       f_rsl_bcch_fill_raw(rsl_si_type, si);</span><br><span>@@ -4852,7 +4852,7 @@</span><br><span>         * support dynamic timeslots?  But it uses the same scheduler as osmo-bts-trx ?!? */</span><br><span>         f_vty_config2(BSCVTY, {"network", "bts 0", "trx 0", "timeslot 3"}, "phys_chan_config TCH/F");</span><br><span>      f_vty_config2(BSCVTY, {"network", "bts 0", "trx 0", "timeslot 4"}, "phys_chan_config TCH/F");</span><br><span style="color: hsl(0, 100%, 40%);">- f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> }</span><br><span> </span><br><span> private function f_virtphy_common() runs on test_CT {</span><br><span>@@ -4926,7 +4926,7 @@</span><br><span>       var octetstring data;</span><br><span>        timer T;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_init_l1ctl();</span><br><span>      f_l1_tune(L1CTL);</span><br><span> </span><br><span>@@ -4982,7 +4982,7 @@</span><br><span> /* Send AGCH from PCU; check it appears on Um side */</span><br><span> testcase TC_pcu_data_req_agch() runs on test_CT {</span><br><span>  timer T := 3.0;</span><br><span style="color: hsl(0, 100%, 40%);">- f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_init_l1ctl();</span><br><span>      f_l1_tune(L1CTL);</span><br><span> </span><br><span>@@ -5004,7 +5004,7 @@</span><br><span> /* Send AGCH from PCU; check it appears on Um side */</span><br><span> testcase TC_pcu_data_req_pch() runs on test_CT {</span><br><span>   timer T := 3.0;</span><br><span style="color: hsl(0, 100%, 40%);">- f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_init_l1ctl();</span><br><span>      f_l1_tune(L1CTL);</span><br><span> </span><br><span>@@ -5027,7 +5027,7 @@</span><br><span> /* Send IMM.ASS from PCU for PCH; check it appears on Um side */</span><br><span> testcase TC_pcu_data_req_imm_ass_pch() runs on test_CT {</span><br><span>        var octetstring imm_ass := f_rnd_octstring(23);</span><br><span style="color: hsl(0, 100%, 40%);">- f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_init_l1ctl();</span><br><span>      f_l1_tune(L1CTL);</span><br><span> </span><br><span>@@ -5050,7 +5050,7 @@</span><br><span> </span><br><span> /* Send RACH from Um side, expect it to show up on PCU socket */</span><br><span> testcase TC_pcu_rach_content() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-       f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_init_l1ctl();</span><br><span>      f_l1_tune(L1CTL);</span><br><span> </span><br><span>@@ -5091,7 +5091,7 @@</span><br><span>        var GsmFrameNumber fn;</span><br><span>       var BIT11 ra11;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_init_l1ctl();</span><br><span>      f_l1_tune(L1CTL);</span><br><span> </span><br><span>@@ -5188,7 +5188,7 @@</span><br><span> </span><br><span> /* Verify C/I (Carrier-to-Interference ratio) processing of PDTCH frames */</span><br><span> testcase TC_pcu_data_ind_lqual_cb() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-       f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         PCU.clear;</span><br><span> </span><br><span>       f_init_l1ctl();</span><br><span>@@ -5217,7 +5217,7 @@</span><br><span> </span><br><span> /* Send PAGING via RSL, expect it to shw up on PCU socket */</span><br><span> testcase TC_pcu_paging_from_rsl() runs on test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-      f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span> </span><br><span>     for (var integer i := 0; i < 100; i := i+1) {</span><br><span>             var MobileIdentityLV mi_lv;</span><br><span>@@ -5262,7 +5262,7 @@</span><br><span>  var float test_duration := 5.0;</span><br><span>      timer T;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_TC_pcu_act_req(0, 0, 7, true);</span><br><span> </span><br><span>         PCU.clear;</span><br><span>@@ -5316,7 +5316,7 @@</span><br><span>   var float test_duration := 5.0;</span><br><span>      timer T;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_TC_pcu_act_req(0, 0, 7, true);</span><br><span> </span><br><span>         PCU.clear;</span><br><span>@@ -5388,7 +5388,7 @@</span><br><span>   var float test_duration := 5.0;</span><br><span>      timer T;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-    f_init_pcu_test();</span><br><span style="color: hsl(120, 100%, 40%);">+    f_init_with_pcuif();</span><br><span>         f_TC_pcu_act_req(0, 0, 7, true);</span><br><span> </span><br><span>         /* re-connect CTRL port from BTS to BSC */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23464">change 23464</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23464"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic95c46426ed3ac9ead645037059190fead181b31 </div>
<div style="display:none"> Gerrit-Change-Number: 23464 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>