<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23416">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
daniel: Looks good to me, approved
lynxis lazus: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: Add comments explaining the nsvc->sns_only field<br><br>Change-Id: I16009a1b03d8027de2be56b7d5013b755c9550fd<br>---<br>M src/gb/gprs_ns2.c<br>M src/gb/gprs_ns2_internal.h<br>M src/gb/gprs_ns2_sns.c<br>3 files changed, 7 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index 4d27333..3574f28 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -1422,6 +1422,9 @@</span><br><span> OSMO_ASSERT(nse);</span><br><span> </span><br><span> llist_for_each_entry(nsvc, &nse->nsvc, list) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* A pre-configured endpoint shall not be used for NSE data or signalling traffic</span><br><span style="color: hsl(120, 100%, 40%);">+ * (with the exception of Size and Configuration procedures) unless it is</span><br><span style="color: hsl(120, 100%, 40%);">+ * configured by the SGSN using the auto-configuration procedures */</span><br><span> if (nsvc->sns_only)</span><br><span> continue;</span><br><span> </span><br><span>diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h</span><br><span>index 29717c6..b4d0a0d 100644</span><br><span>--- a/src/gb/gprs_ns2_internal.h</span><br><span>+++ b/src/gb/gprs_ns2_internal.h</span><br><span>@@ -220,6 +220,7 @@</span><br><span> void *priv;</span><br><span> </span><br><span> bool nsvci_is_valid;</span><br><span style="color: hsl(120, 100%, 40%);">+ /*! should this NS-VC only be used for SNS-SIZE and SNS-CONFIG? */</span><br><span> bool sns_only;</span><br><span> </span><br><span> struct rate_ctr_group *ctrg;</span><br><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 11c5a8e..51e4e9e 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -914,6 +914,9 @@</span><br><span> gss->sns_nsvc = ns2_ip_bind_connect(bind, gss->nse, remote);</span><br><span> if (!gss->sns_nsvc)</span><br><span> return;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* A pre-configured endpoint shall not be used for NSE data or signalling traffic</span><br><span style="color: hsl(120, 100%, 40%);">+ * (with the exception of Size and Configuration procedures) unless it is configured</span><br><span style="color: hsl(120, 100%, 40%);">+ * by the SGSN using the auto-configuration procedures */</span><br><span> gss->sns_nsvc->sns_only = true;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23416">change 23416</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23416"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16009a1b03d8027de2be56b7d5013b755c9550fd </div>
<div style="display:none"> Gerrit-Change-Number: 23416 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>