<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23417">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_sns: Fix memory leak when creating ip[46]_local arrays<br><br>Prior to this patch, we would unconditionally allocate new memory<br>for the local SNS IP endpoints.   This results in a memory leak<br>on every SNS-SIZE procedure.<br><br>Let's move to talloc_realloc() which recycles any previously allocated<br>memory.<br><br>Change-Id: I12cb670e087c6d6190f3f5bf8483ea62008ae06f<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 2 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/23417/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index f05a8e6..f766508 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -805,7 +805,7 @@</span><br><span> </span><br><span>        switch (gss->ip) {</span><br><span>        case IPv4:</span><br><span style="color: hsl(0, 100%, 40%);">-              ip4_elems = talloc_zero_size(fi, sizeof(struct gprs_ns_ie_ip4_elem) * count);</span><br><span style="color: hsl(120, 100%, 40%);">+         ip4_elems = talloc_realloc(fi, gss->ip4_local, struct gprs_ns_ie_ip4_elem, count);</span><br><span>                if (!ip4_elems)</span><br><span>                      return;</span><br><span> </span><br><span>@@ -840,7 +840,7 @@</span><br><span>            break;</span><br><span>       case IPv6:</span><br><span>           /* IPv6 */</span><br><span style="color: hsl(0, 100%, 40%);">-              ip6_elems = talloc_zero_size(fi, sizeof(struct gprs_ns_ie_ip6_elem) * count);</span><br><span style="color: hsl(120, 100%, 40%);">+         ip6_elems = talloc_realloc(fi, gss->ip6_local, struct gprs_ns_ie_ip6_elem, count);</span><br><span>                if (!ip6_elems)</span><br><span>                      return;</span><br><span> </span><br><span>@@ -919,7 +919,6 @@</span><br><span>            gss->sns_nsvc->sns_only = true;</span><br><span>        }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        if (gss->num_max_ip4_remote > 0)</span><br><span>               ns2_tx_sns_size(gss->sns_nsvc, true, gss->num_max_nsvcs, gss->num_max_ip4_remote, -1);</span><br><span>      else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23417">change 23417</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23417"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I12cb670e087c6d6190f3f5bf8483ea62008ae06f </div>
<div style="display:none"> Gerrit-Change-Number: 23417 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>