<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23411">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_sns: Assume the SGSN has a very large number of max. NSVC<br><br>It is the SGSN's job to ensure sufficient NS-VC capacity.  As the SGSN<br>doesn't tell the BSS, we should not make assumptions of only 4.<br><br>Change-Id: I41f493643cf51d7853959ab9c7bbc0ffae4e1f4b<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/23411/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index c2c5b5e..49768c1 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -811,7 +811,6 @@</span><br><span>                 }</span><br><span> </span><br><span>                gss->num_ip4_local = count;</span><br><span style="color: hsl(0, 100%, 40%);">-          gss->num_max_ip4_remote = 4;</span><br><span>              gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip4_remote * gss->num_ip4_local, 8);</span><br><span>             break;</span><br><span>       case IPv6:</span><br><span>@@ -848,7 +847,6 @@</span><br><span>                     ip6_elems++;</span><br><span>                 }</span><br><span>            gss->num_ip6_local = count;</span><br><span style="color: hsl(0, 100%, 40%);">-          gss->num_max_ip6_remote = 4;</span><br><span>              gss->num_max_nsvcs = OSMO_MAX(gss->num_max_ip6_remote * gss->num_ip6_local, 8);</span><br><span>             break;</span><br><span>       }</span><br><span>@@ -1559,6 +1557,9 @@</span><br><span>    fi->priv = gss;</span><br><span>   gss->nse = nse;</span><br><span>   gss->role = GPRS_SNS_ROLE_BSS;</span><br><span style="color: hsl(120, 100%, 40%);">+     /* The SGSN doesn't tell the BSS, so we assume there's always sufficient */</span><br><span style="color: hsl(120, 100%, 40%);">+   gss->num_max_ip4_remote = 8192;</span><br><span style="color: hsl(120, 100%, 40%);">+    gss->num_max_ip6_remote = 8192;</span><br><span>   INIT_LLIST_HEAD(&gss->sns_endpoints);</span><br><span>         INIT_LLIST_HEAD(&gss->binds);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23411">change 23411</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23411"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I41f493643cf51d7853959ab9c7bbc0ffae4e1f4b </div>
<div style="display:none"> Gerrit-Change-Number: 23411 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>