<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23390">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">stats: log error when missing stats values<br><br>Let the user know when the stats were not consumed fast enough for the<br>given FIFO length.<br><br>Related: SYS#4877<br>Change-Id: If0e8ab55103007693101538fb6ea310075217774<br>---<br>M src/stat_item.c<br>M tests/stats/stats_test.c<br>M tests/stats/stats_test.err<br>3 files changed, 156 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/23390/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/stat_item.c b/src/stat_item.c</span><br><span>index ba36464..78e57a6 100644</span><br><span>--- a/src/stat_item.c</span><br><span>+++ b/src/stat_item.c</span><br><span>@@ -60,6 +60,7 @@</span><br><span> #include <osmocom/core/talloc.h></span><br><span> #include <osmocom/core/timer.h></span><br><span> #include <osmocom/core/stat_item.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/logging.h></span><br><span> </span><br><span> /*! global list of stat_item groups */</span><br><span> static LLIST_HEAD(osmo_stat_item_groups);</span><br><span>@@ -242,6 +243,10 @@</span><br><span> </span><br><span> idx_delta = item_value->id + 1 - *next_idx;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (idx_delta > 1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DLSTATS, LOGL_ERROR, "%s: %i stats values skipped\n", item->desc->name, idx_delta - 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> *next_idx = item_value->id + 1;</span><br><span> </span><br><span> return idx_delta;</span><br><span>diff --git a/tests/stats/stats_test.c b/tests/stats/stats_test.c</span><br><span>index 707f606..b81ad6b 100644</span><br><span>--- a/tests/stats/stats_test.c</span><br><span>+++ b/tests/stats/stats_test.c</span><br><span>@@ -120,6 +120,7 @@</span><br><span> value = osmo_stat_item_get_last(statg->items[TEST_A_ITEM]);</span><br><span> OSMO_ASSERT(value == -1);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "osmo_stat_item_get_next rc == 0\n");</span><br><span> rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);</span><br><span> OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span>@@ -128,13 +129,16 @@</span><br><span> value = osmo_stat_item_get_last(statg->items[TEST_A_ITEM]);</span><br><span> OSMO_ASSERT(value == 1);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "osmo_stat_item_get_next rc > 0\n");</span><br><span> rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);</span><br><span> OSMO_ASSERT(rc > 0);</span><br><span> OSMO_ASSERT(value == 1);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "osmo_stat_item_get_next rc == 0\n");</span><br><span> rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);</span><br><span> OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "osmo_stat_item_get_next rc > 0\n");</span><br><span> for (i = 2; i <= 32; i++) {</span><br><span> osmo_stat_item_set(statg->items[TEST_A_ITEM], i);</span><br><span> osmo_stat_item_set(statg->items[TEST_B_ITEM], 1000 + i);</span><br><span>@@ -220,17 +224,20 @@</span><br><span> rc = osmo_stat_item_discard(statg->items[TEST_A_ITEM], &rd_a);</span><br><span> OSMO_ASSERT(rc > 0);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "osmo_stat_item_get_next rc == 0\n");</span><br><span> rc = osmo_stat_item_discard(statg->items[TEST_A_ITEM], &rd_a);</span><br><span> OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span> rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);</span><br><span> OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "osmo_stat_item_get_next rc > 0\n");</span><br><span> osmo_stat_item_set(statg->items[TEST_A_ITEM], 98);</span><br><span> rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);</span><br><span> OSMO_ASSERT(rc > 0);</span><br><span> OSMO_ASSERT(value == 98);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "osmo_stat_item_get_next rc == 0\n");</span><br><span> rc = osmo_stat_item_get_next(statg->items[TEST_A_ITEM], &rd_a, &value);</span><br><span> OSMO_ASSERT(rc == 0);</span><br><span> </span><br><span>diff --git a/tests/stats/stats_test.err b/tests/stats/stats_test.err</span><br><span>index 3accf54..d059ffd 100644</span><br><span>--- a/tests/stats/stats_test.err</span><br><span>+++ b/tests/stats/stats_test.err</span><br><span>@@ -1,3 +1,147 @@</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_stat_item_get_next rc == 0</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_stat_item_get_next rc > 0</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_stat_item_get_next rc == 0</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_stat_item_get_next rc > 0</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 3 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 4 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 57 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.a: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 51 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+DLSTATS ERROR item.b: 1 stats values skipped</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_stat_item_get_next rc == 0</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_stat_item_get_next rc > 0</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_stat_item_get_next rc == 0</span><br><span> Start test: test_reporting</span><br><span> DLGLOBAL ERROR counter group 'ctr-test:one' already exists for index 2, instead using index 3. This is a software bug that needs fixing.</span><br><span> DLGLOBAL ERROR 'ctr-test.one_dot' is not a valid counter group identifier</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23390">change 23390</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23390"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If0e8ab55103007693101538fb6ea310075217774 </div>
<div style="display:none"> Gerrit-Change-Number: 23390 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>