<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23322">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bts-trx: Avoid submitting first data_ind with FN=0 to upper layers<br><br>It can happen that the first burst we receive after enabling the PDCH<br>channel (when PCU connects to the BTS) is bid!=0. As a result,<br>chan_state->ul_first_fn is never set and defautl value 0 in there is<br>passed to the upper layers. As a result, when the 2nd block is<br>transmitted, this time with correct FN, the PCU will see a huge jump in<br>FNs. Since in PDCH the bursts are always consecutive, let's simply use<br>bi->fn - 3 as a first_fn and be done with the issue.<br><br>Related: OS#5020<br>Change-Id: Ie982caeb29f3ffd880b44e88a89b85ea3e6e6947<br>---<br>M src/osmo-bts-trx/sched_lchan_pdtch.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/22/23322/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bts-trx/sched_lchan_pdtch.c b/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>index 665f643..5e61a1d 100644</span><br><span>--- a/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>+++ b/src/osmo-bts-trx/sched_lchan_pdtch.c</span><br><span>@@ -44,7 +44,7 @@</span><br><span>        struct l1sched_ts *l1ts = l1sched_trx_get_ts(l1t, bi->tn);</span><br><span>        struct l1sched_chan_state *chan_state = &l1ts->chan_state[chan];</span><br><span>      sbit_t *burst, **bursts_p = &chan_state->ul_bursts;</span><br><span style="color: hsl(0, 100%, 40%);">-      uint32_t *first_fn = &chan_state->ul_first_fn;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t first_fn;</span><br><span>   uint8_t *mask = &chan_state->ul_mask;</span><br><span>         struct l1sched_meas_set meas_avg;</span><br><span>    uint8_t l2[EGPRS_0503_MAX_BYTES];</span><br><span>@@ -70,7 +70,6 @@</span><br><span>        if (bid == 0) {</span><br><span>              memset(*bursts_p, 0, GSM0503_EGPRS_BURSTS_NBITS);</span><br><span>            *mask = 0x0;</span><br><span style="color: hsl(0, 100%, 40%);">-            *first_fn = bi->fn;</span><br><span>       }</span><br><span> </span><br><span>        /* update mask */</span><br><span>@@ -141,8 +140,9 @@</span><br><span> </span><br><span>  ber10k = compute_ber10k(n_bits_total, n_errors);</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  first_fn = GSM_TDMA_FN_SUB(bi->fn, 3);</span><br><span>    return _sched_compose_ph_data_ind(l1t, bi->tn,</span><br><span style="color: hsl(0, 100%, 40%);">-                                         *first_fn, chan, l2, rc,</span><br><span style="color: hsl(120, 100%, 40%);">+                                      first_fn, chan, l2, rc,</span><br><span>                                      meas_avg.rssi, meas_avg.toa256,</span><br><span>                                      meas_avg.ci_cb, ber10k,</span><br><span>                                      presence_info);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23322">change 23322</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23322"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie982caeb29f3ffd880b44e88a89b85ea3e6e6947 </div>
<div style="display:none"> Gerrit-Change-Number: 23322 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>