<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/23249">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: Transmit pdtch invalid MAC blocks to PCU<br><br>Similar to what we have been doing for TCH channels, we want to make<br>sure all MAC blocks get to the upper layers, even if containing invalid<br>data (flagging it with data_len=0) so that upper layers (osmo-pcu<br>through PCUIF in this case) can rely on FN clock without gaps due to<br>Rx errors.<br><br>Related: OS#5020<br>Change-Id: I0b04b013b7bad5ff53d6a969ff0128b37f7f62d5<br>---<br>M src/common/l1sap.c<br>M src/common/pcu_sock.c<br>2 files changed, 4 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 0600658..9bb8be3 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1530,12 +1530,9 @@</span><br><span>                         return 1;</span><br><span>            }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-           /* don't send bad frames to PCU */</span><br><span style="color: hsl(0, 100%, 40%);">-          if (len == 0)</span><br><span style="color: hsl(0, 100%, 40%);">-                   return -EINVAL;</span><br><span style="color: hsl(0, 100%, 40%);">-         /* drop incomplete UL block */</span><br><span style="color: hsl(120, 100%, 40%);">+                /* Drop all data from incomplete UL block */</span><br><span>                 if (pr_info != PRES_INFO_BOTH)</span><br><span style="color: hsl(0, 100%, 40%);">-                  return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+                     len = 0;</span><br><span> </span><br><span>                 /* PDTCH / PACCH frame handling */</span><br><span>           pcu_tx_data_ind(&trx->ts[tn], PCU_IF_SAPI_PDTCH, fn, trx->arfcn,</span><br><span>diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c</span><br><span>index ec7f876..2d44e02 100644</span><br><span>--- a/src/common/pcu_sock.c</span><br><span>+++ b/src/common/pcu_sock.c</span><br><span>@@ -501,7 +501,8 @@</span><br><span>    data_ind->ber10k = ber10k;</span><br><span>        data_ind->ta_offs_qbits = bto;</span><br><span>    data_ind->lqual_cb = lqual;</span><br><span style="color: hsl(0, 100%, 40%);">-  memcpy(data_ind->data, data, len);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (len)</span><br><span style="color: hsl(120, 100%, 40%);">+              memcpy(data_ind->data, data, len);</span><br><span>        data_ind->len = len;</span><br><span> </span><br><span>  return pcu_sock_send(&bts_gsmnet, msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/23249">change 23249</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/23249"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0b04b013b7bad5ff53d6a969ff0128b37f7f62d5 </div>
<div style="display:none"> Gerrit-Change-Number: 23249 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>