<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/23306">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove some outdated TODO/comments<br><br>Change-Id: Icd72ed92585f5701d293807022255b06e5641005<br>---<br>M include/osmocom/sgsn/gb_proxy.h<br>M src/gb_proxy.c<br>2 files changed, 1 insertion(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/06/23306/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/sgsn/gb_proxy.h b/include/osmocom/sgsn/gb_proxy.h</span><br><span>index c9d2fca..2a800e5 100644</span><br><span>--- a/include/osmocom/sgsn/gb_proxy.h</span><br><span>+++ b/include/osmocom/sgsn/gb_proxy.h</span><br><span>@@ -165,7 +165,7 @@</span><br><span>       /* NSEI of the NSE */</span><br><span>        uint16_t nsei;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      /* Maximum side of the NS-UNITDATA NS SDU that can be transported by the NSE */</span><br><span style="color: hsl(120, 100%, 40%);">+       /* Maximum size of the NS-UNITDATA NS SDU that can be transported by the NSE */</span><br><span>      uint16_t max_sdu_len;</span><br><span> </span><br><span>    /* Are we facing towards a SGSN (true) or BSS (false) */</span><br><span>diff --git a/src/gb_proxy.c b/src/gb_proxy.c</span><br><span>index ba99aec..f448c0b 100644</span><br><span>--- a/src/gb_proxy.c</span><br><span>+++ b/src/gb_proxy.c</span><br><span>@@ -1128,8 +1128,6 @@</span><br><span>        int errctr = GBPROX_GLOB_CTR_PROTO_ERR_SGSN;</span><br><span>         int i, j;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* FIXME: Handle paging logic to only page each matching NSE */</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>      if (TLVP_PRES_LEN(tp, BSSGP_IE_BVCI, 2)) {</span><br><span>           uint16_t bvci = ntohs(tlvp_val16_unal(tp, BSSGP_IE_BVCI));</span><br><span>           errctr = GBPROX_GLOB_CTR_OTHER_ERR;</span><br><span>@@ -1514,8 +1512,6 @@</span><br><span> /*  TODO: What about handling:</span><br><span>  *     GPRS_NS2_AFF_CAUSE_VC_FAILURE,</span><br><span>       GPRS_NS2_AFF_CAUSE_VC_RECOVERY,</span><br><span style="color: hsl(0, 100%, 40%);">- GPRS_NS2_AFF_CAUSE_FAILURE,</span><br><span style="color: hsl(0, 100%, 40%);">-     GPRS_NS2_AFF_CAUSE_RECOVERY,</span><br><span>         osmocom own causes</span><br><span>   GPRS_NS2_AFF_CAUSE_SNS_CONFIGURED,</span><br><span>   GPRS_NS2_AFF_CAUSE_SNS_FAILURE,</span><br><span>@@ -1524,8 +1520,6 @@</span><br><span> void gprs_ns_prim_status_cb(struct gbproxy_config *cfg, struct osmo_gprs_ns2_prim *nsp)</span><br><span> {</span><br><span>      /* TODO: bss nsei available/unavailable  bssgp_tx_simple_bvci(BSSGP_PDUT_BVC_BLOCK, nsvc->nsei, bvc->bvci, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-     * TODO: sgsn nsei available/unavailable</span><br><span style="color: hsl(0, 100%, 40%);">-         * TODO: Update MTU</span><br><span>   */</span><br><span> </span><br><span>      struct gbproxy_bvc *bvc;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/23306">change 23306</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gbproxy/+/23306"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-gbproxy </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd72ed92585f5701d293807022255b06e5641005 </div>
<div style="display:none"> Gerrit-Change-Number: 23306 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>