<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17283">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">transport/pcsc: work around Python 3.5 bug: guard disconnect()<br><br>Unfortunately, Debian ships old Python (3.5 vs 3.8) and old pyscard<br>(1.9.4 vs 1.9.9). Calling PCSCCardConnection.disconnect() from a<br>destructor causes warnings about ignored exceptions:<br><br>  AttributeError: 'NoneType' object has no attribute 'disconnect'<br>  AttributeError: 'NoneType' object has no attribute 'setChanged'<br>  AttributeError: 'NoneType' object has no attribute 'SCardDisconnect'<br>  TypeError: 'NoneType' object is not callable<br><br>All these exceptions happen in pyscard's own destructors.<br><br>Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee<br>---<br>M pySim/transport/pcsc.py<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/transport/pcsc.py b/pySim/transport/pcsc.py</span><br><span>index fadf6f9..2c2cbb9 100644</span><br><span>--- a/pySim/transport/pcsc.py</span><br><span>+++ b/pySim/transport/pcsc.py</span><br><span>@@ -39,7 +39,11 @@</span><br><span>                self._con = self._reader.createConnection()</span><br><span> </span><br><span>      def __del__(self):</span><br><span style="color: hsl(0, 100%, 40%);">-              self._con.disconnect()</span><br><span style="color: hsl(120, 100%, 40%);">+                try:</span><br><span style="color: hsl(120, 100%, 40%);">+                  # FIXME: this causes multiple warnings in Python 3.5.3</span><br><span style="color: hsl(120, 100%, 40%);">+                        self._con.disconnect()</span><br><span style="color: hsl(120, 100%, 40%);">+                except:</span><br><span style="color: hsl(120, 100%, 40%);">+                       pass</span><br><span>                 return</span><br><span> </span><br><span>   def wait_for_card(self, timeout=None, newcardonly=False):</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17283">change 17283</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17283"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee </div>
<div style="display:none"> Gerrit-Change-Number: 17283 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>