<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23223">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_sns: Dispatch inbound SNS-ACK to FSM<br><br>We don't really handle inbound SNS-ACK yet (as we don't originate<br>SNS ADD/DEL/CHGWEIGHT procedures yet).  However, the message<br>receive code should already dispatch those events to the FSM,<br>just like we do for the (equally unimplemented) handling of inbound<br>SNS-SIZE which is already dispatched to the FSM.<br><br>Change-Id: If6d5f96d85e6f05534fe49376f4473d912535ad4<br>---<br>M src/gb/gprs_ns2_sns.c<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/23/23223/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c</span><br><span>index 698f60a..0bb7422 100644</span><br><span>--- a/src/gb/gprs_ns2_sns.c</span><br><span>+++ b/src/gb/gprs_ns2_sns.c</span><br><span>@@ -79,6 +79,7 @@</span><br><span>  GPRS_SNS_EV_RX_ADD,</span><br><span>  GPRS_SNS_EV_RX_DELETE,</span><br><span>       GPRS_SNS_EV_RX_CHANGE_WEIGHT,</span><br><span style="color: hsl(120, 100%, 40%);">+ GPRS_SNS_EV_RX_ACK,                     /*!< Rx of SNS-ACK (response to ADD/DELETE/CHG_WEIGHT */</span><br><span>  GPRS_SNS_EV_REQ_NO_NSVC,                /*!< no more NS-VC remaining (all dead) */</span><br><span>        GPRS_SNS_EV_REQ_NSVC_ALIVE,             /*!< a NS-VC became alive */</span><br><span>      GPRS_SNS_EV_REQ_ADD_BIND,               /*!< add a new local bind to this NSE */</span><br><span>@@ -94,6 +95,7 @@</span><br><span>      { GPRS_SNS_EV_RX_CONFIG_ACK,            "RX_CONFIG_ACK" },</span><br><span>         { GPRS_SNS_EV_RX_ADD,                   "RX_ADD" },</span><br><span>        { GPRS_SNS_EV_RX_DELETE,                "RX_DELETE" },</span><br><span style="color: hsl(120, 100%, 40%);">+      { GPRS_SNS_EV_RX_ACK,                   "RX_ACK" },</span><br><span>        { GPRS_SNS_EV_RX_CHANGE_WEIGHT,         "RX_CHANGE_WEIGHT" },</span><br><span>      { GPRS_SNS_EV_REQ_NO_NSVC,              "REQ_NO_NSVC" },</span><br><span>   { GPRS_SNS_EV_REQ_NSVC_ALIVE,           "REQ_NSVC_ALIVE"},</span><br><span>@@ -1599,8 +1601,7 @@</span><br><span>                 osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_RX_CHANGE_WEIGHT, tp);</span><br><span>                break;</span><br><span>       case SNS_PDUT_ACK:</span><br><span style="color: hsl(0, 100%, 40%);">-              LOGPFSML(fi, LOGL_NOTICE, "NSEI=%u Rx unsupported SNS PDU type %s\n", nsei,</span><br><span style="color: hsl(0, 100%, 40%);">-                    get_value_string(gprs_ns_pdu_strings, nsh->pdu_type));</span><br><span style="color: hsl(120, 100%, 40%);">+            osmo_fsm_inst_dispatch(fi, GPRS_SNS_EV_RX_ACK, tp);</span><br><span>          break;</span><br><span>       default:</span><br><span>             LOGPFSML(fi, LOGL_ERROR, "NSEI=%u Rx unknown SNS PDU type %s\n", nsei,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23223">change 23223</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23223"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If6d5f96d85e6f05534fe49376f4473d912535ad4 </div>
<div style="display:none"> Gerrit-Change-Number: 23223 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>