<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23232">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pcu: Introduce test TC_n3101_max_t3169<br><br>This test currently fails to pass in master osmo-pcu (and latest) due to<br>T3169 not being implemented exactly as per specs (due to limitations in<br>detecting lost UL blocks with assigned USF).<br><br>Related: OS#5033<br>Change-Id: I56177850f084cdaf4fcac63ebdcdff9cef4e7a5d<br>---<br>M pcu/GPRS_Components.ttcn<br>M pcu/PCU_Tests.ttcn<br>2 files changed, 121 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/23232/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn</span><br><span>index 5266743..57cd837 100644</span><br><span>--- a/pcu/GPRS_Components.ttcn</span><br><span>+++ b/pcu/GPRS_Components.ttcn</span><br><span>@@ -701,6 +701,20 @@</span><br><span> return 0; /* make compiler happy */</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+function f_rlcmac_dl_block_get_usf(RlcmacDlBlock dl_block)</span><br><span style="color: hsl(120, 100%, 40%);">+runs on MS_BTS_IFACE_CT return uint3_t {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ischosen(dl_block.data)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ return dl_block.data.mac_hdr.mac_hdr.usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (ischosen(dl_block.data_egprs)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ return dl_block.data_egprs.mac_hdr.usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else { /* Ctrl block */</span><br><span style="color: hsl(120, 100%, 40%);">+ return dl_block.ctrl.mac_hdr.usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "DlBlock doesn't contain a USF:", dl_block);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0; /* make compiler happy */</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Get the Chan coding command from a dl block containing PACCH UL Assignment */</span><br><span> function f_rlcmac_dl_block_get_assigned_ul_cs_mcs(RlcmacDlBlock dl_block)</span><br><span> runs on MS_BTS_IFACE_CT return CodingScheme {</span><br><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index c60e49e..e0fe36f 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -1313,6 +1313,112 @@</span><br><span> f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Validate what happens when RACH to get UL TBF and then PCU receives no UL</span><br><span style="color: hsl(120, 100%, 40%);">+ * data. It should end up in N3101 reaching N3101_MAX and finally triggering</span><br><span style="color: hsl(120, 100%, 40%);">+ * T3169. See OS#5033 */</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_n3101_max_t3169() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PCUIF_info_ind info_ind;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template (value) TsTrxBtsNum nr;</span><br><span style="color: hsl(120, 100%, 40%);">+ var BTS_PDTCH_Block data_msg;</span><br><span style="color: hsl(120, 100%, 40%);">+ var GprsMS ms;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint3_t rx_usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ const integer N3101_MAX := 9; /* N3101 shall be reat than 8 */</span><br><span style="color: hsl(120, 100%, 40%);">+ var integer n3101 := 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T_3169 := 1.0;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize NS/BSSGP side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_bssgp();</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize GPRS MS side */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_gprs_ms();</span><br><span style="color: hsl(120, 100%, 40%);">+ ms := g_ms[0]; /* We only use first MS in this test */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Initialize the PCU interface abstraction */</span><br><span style="color: hsl(120, 100%, 40%);">+ info_ind := valueof(ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS));</span><br><span style="color: hsl(120, 100%, 40%);">+ info_ind.n3101 := N3101_MAX; /* N3101 shall be reat than 8 */</span><br><span style="color: hsl(120, 100%, 40%);">+ info_ind.t3169 := 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init_raw(testcasename(), info_ind);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish BSSGP connection to the PCU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_establish();</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Establish UL TBF */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now we wait for PCU to transmit our USF */</span><br><span style="color: hsl(120, 100%, 40%);">+ nr := ts_TsTrxBtsNum;</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ sapi := PCU_IF_SAPI_PDTCH, fn := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)),</span><br><span style="color: hsl(120, 100%, 40%);">+ block_nr := nr.blk_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ tr_PCUIF_DATA(nr.trx_nr, nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),</span><br><span style="color: hsl(120, 100%, 40%);">+ ?)) -> value data_msg {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ms.ul_tbf.usf[valueof(nr.ts_nr)] == USF_UNUSED) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected ts_nr ", valueof(nr.ts_nr), " without USF allocated");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rx_usf := f_rlcmac_dl_block_get_usf(data_msg.dl_block);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("PCU requests our USF ", rx_usf, ", n3101=", n3101);</span><br><span style="color: hsl(120, 100%, 40%);">+ n3101 := n3101 + 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ //"if (n3101 > N3101_MAX) {" -> start timer T3169</span><br><span style="color: hsl(120, 100%, 40%);">+ if (n3101 > N3101_MAX) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Reached ", n3101, " > ", N3101_MAX, " (N3101_MAX) and PCU still sends us USFs");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (rx_usf == USF_UNUSED and n3101 == N3101_MAX) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* If we already received USFs for us and we don't receive them anymore, that means the TBF entered T3169 */</span><br><span style="color: hsl(120, 100%, 40%);">+ log("PCU stopped requesting USF ", ms.ul_tbf.usf[valueof(nr.ts_nr)]);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not T_3169.running) {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("T3169 started");</span><br><span style="color: hsl(120, 100%, 40%);">+ T_3169.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if(rx_usf == USF_UNUSED and n3101 > 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "PCU stopped requesting USFs too early: ", n3101, " < ", N3101_MAX, " (N3101_MAX)");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("PCU requests ", rx_usf, ", we have ", ms.ul_tbf.usf[valueof(nr.ts_nr)]);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ nr := ts_TsTrxBtsNum;</span><br><span style="color: hsl(120, 100%, 40%);">+ BTS.send(ts_PCUIF_RTS_REQ(nr.bts_nr, nr.trx_nr, nr.ts_nr,</span><br><span style="color: hsl(120, 100%, 40%);">+ sapi := PCU_IF_SAPI_PDTCH, fn := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ arfcn := f_trxnr2arfcn(valueof(nr.trx_nr)),</span><br><span style="color: hsl(120, 100%, 40%);">+ block_nr := nr.blk_nr));</span><br><span style="color: hsl(120, 100%, 40%);">+ repeat;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T_3169.timeout {</span><br><span style="color: hsl(120, 100%, 40%);">+ log("T_3169 expired");</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Done in alt */</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] BTS.receive {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected BTS message");</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now that T3169 has expired, establishing a Ul TBF should provide same</span><br><span style="color: hsl(120, 100%, 40%);">+ /* USFs as per previous TBF since they were freed at expiration time: */</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint3_t old_usf[8] := ms.ul_tbf.usf;</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint5_t old_tfi := ms.ul_tbf.tfi;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_ms_establish_ul_tbf(ms);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (old_tfi != ms.ul_tbf.tfi) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected TFI change: ", ms.ul_tbf.tfi, " vs exp ", old_tfi);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i := 0; i < 8; i := i +1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ms.ul_tbf.usf[i] != old_usf[i]) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected USF change: ", ms.ul_tbf.usf[i], " vs exp ", old_usf[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_shutdown(__BFILE__, __LINE__, final := true);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* Verify that a Downlink TBF is kept available until T3191 fires, at which</span><br><span> * point the TBF is no longer available. In order to get to start of T3191, we</span><br><span> * have to wait for x2031 since that marks the IDLE TBF time, that is, the delay</span><br><span>@@ -5530,6 +5636,7 @@</span><br><span> execute( TC_mcs_initial_dl() );</span><br><span> execute( TC_mcs_max_dl() );</span><br><span> execute( TC_t3169() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_n3101_max_t3169() );</span><br><span> execute( TC_x2031_t3191() );</span><br><span> execute( TC_zero_x2031_t3191() );</span><br><span> execute( TC_t3193() );</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23232">change 23232</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23232"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I56177850f084cdaf4fcac63ebdcdff9cef4e7a5d </div>
<div style="display:none"> Gerrit-Change-Number: 23232 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>