<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23222">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: Log all transmitted SNS messages<br><br>We already have similar log statements for all NS-{RESET,BLOCK,UNBLOCK,...}<br>and it's confusing that even a debug-level NS log file doesn't show<br>transmitting SNS messages at all.<br><br>Change-Id: I0d31c3911d3acd6ac7296c370e920d53412d8289<br>---<br>M src/gb/gprs_ns2_message.c<br>1 file changed, 15 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/22/23222/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_message.c b/src/gb/gprs_ns2_message.c</span><br><span>index ddf7285..cf075ec 100644</span><br><span>--- a/src/gb/gprs_ns2_message.c</span><br><span>+++ b/src/gb/gprs_ns2_message.c</span><br><span>@@ -515,6 +515,9 @@</span><br><span>                return -EIO;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGNSVC(nsvc, LOGL_INFO, "Tx SNS-ACK (trans_id=%u, cause=%s, num_ip4=%u, num_ip6=%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+            trans_id, cause ? gprs_ns2_cause_str(*cause) : "NULL", num_ip4_elems, num_ip6_elems);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    nsei = osmo_htons(nsvc->nse->nsei);</span><br><span> </span><br><span>        msg->l2h = msgb_put(msg, sizeof(*nsh));</span><br><span>@@ -573,6 +576,9 @@</span><br><span>             return -EIO;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGNSVC(nsvc, LOGL_INFO, "Tx SNS-CONFIG (end_flag=%u, num_ip4=%u, num_ip6=%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+           end_flag, num_ip4_elems, num_ip6_elems);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>   nsei = osmo_htons(nsvc->nse->nsei);</span><br><span> </span><br><span>        msg->l2h = msgb_put(msg, sizeof(*nsh));</span><br><span>@@ -621,6 +627,9 @@</span><br><span>             return -EIO;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGNSVC(nsvc, LOGL_INFO, "Tx SNS-CONFIG-ACK (cause=%s)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+          cause ? gprs_ns2_cause_str(*cause) : "NULL");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    nsei = osmo_htons(nsvc->nse->nsei);</span><br><span> </span><br><span>        msg->l2h = msgb_put(msg, sizeof(*nsh));</span><br><span>@@ -666,6 +675,9 @@</span><br><span>             return -EIO;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGNSVC(nsvc, LOGL_INFO, "Tx SNS-SIZE (reset=%u, max_nr_nsvc=%u, num_ip4=%u, num_ip6=%u)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                reset_flag, max_nr_nsvc, ip4_ep_nr, ip6_ep_nr);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    nsei = osmo_htons(nsvc->nse->nsei);</span><br><span> </span><br><span>        msg->l2h = msgb_put(msg, sizeof(*nsh));</span><br><span>@@ -705,6 +717,9 @@</span><br><span>             return -EIO;</span><br><span>         }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGNSVC(nsvc, LOGL_INFO, "Tx SNS-SIZEG-ACK (cause=%s)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+           cause ? gprs_ns2_cause_str(*cause) : "NULL");</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>    nsei = osmo_htons(nsvc->nse->nsei);</span><br><span> </span><br><span>        msg->l2h = msgb_put(msg, sizeof(*nsh));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23222">change 23222</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23222"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0d31c3911d3acd6ac7296c370e920d53412d8289 </div>
<div style="display:none"> Gerrit-Change-Number: 23222 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>