<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/23224">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: Pass peer/remote sockaddr argument to ns2_create_vc()<br><br>This is a preparation towards auto-creating SNS NS-VCs in SGSN role<br><br>Change-Id: Idf92712079cd9b7e4ff2cf8df314b372d63e6e52<br>---<br>M src/gb/gprs_ns2.c<br>M src/gb/gprs_ns2_frgre.c<br>M src/gb/gprs_ns2_internal.h<br>M src/gb/gprs_ns2_udp.c<br>4 files changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/23224/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index a79dd05..4a98374 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -868,12 +868,14 @@</span><br><span> /*! Create a new NS-VC based on a [received] message. Depending on the bind it might create a NSE.</span><br><span>  *  \param[in] bind the bind through which msg was received</span><br><span>  *  \param[in] msg the actual received message</span><br><span style="color: hsl(120, 100%, 40%);">+ *  \param[in] remote address of remote peer sending message</span><br><span>  *  \param[in] logname A name to describe the VC. E.g. ip address pair</span><br><span>  *  \param[out] reject A message filled to be sent back. Only used in failure cases.</span><br><span>  *  \param[out] success A pointer which will be set to the new VC on success</span><br><span>  *  \return enum value indicating the status, e.g. GPRS_NS2_CS_CREATED */</span><br><span> enum ns2_cs ns2_create_vc(struct gprs_ns2_vc_bind *bind,</span><br><span>                         struct msgb *msg,</span><br><span style="color: hsl(120, 100%, 40%);">+                     const struct osmo_sockaddr *remote,</span><br><span>                          const char *logname,</span><br><span>                         struct msgb **reject,</span><br><span>                        struct gprs_ns2_vc **success)</span><br><span>diff --git a/src/gb/gprs_ns2_frgre.c b/src/gb/gprs_ns2_frgre.c</span><br><span>index 62d87a4..76c0b92 100644</span><br><span>--- a/src/gb/gprs_ns2_frgre.c</span><br><span>+++ b/src/gb/gprs_ns2_frgre.c</span><br><span>@@ -447,7 +447,7 @@</span><br><span>       rc = ns2_find_vc_by_dlci(bind, dlci, &nsvc);</span><br><span>     if (rc) {</span><br><span>            /* VC not found */</span><br><span style="color: hsl(0, 100%, 40%);">-              rc = ns2_create_vc(bind, msg, "newconnection", &reject, &nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+             rc = ns2_create_vc(bind, msg, &saddr, "newconnection", &reject, &nsvc);</span><br><span>                switch (rc) {</span><br><span>                case NS2_CS_FOUND:</span><br><span>                   break;</span><br><span>diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h</span><br><span>index 7e235be..80e664c 100644</span><br><span>--- a/src/gb/gprs_ns2_internal.h</span><br><span>+++ b/src/gb/gprs_ns2_internal.h</span><br><span>@@ -279,6 +279,7 @@</span><br><span> </span><br><span> enum ns2_cs ns2_create_vc(struct gprs_ns2_vc_bind *bind,</span><br><span>                           struct msgb *msg,</span><br><span style="color: hsl(120, 100%, 40%);">+                             const struct osmo_sockaddr *remote,</span><br><span>                          const char *logname,</span><br><span>                         struct msgb **reject,</span><br><span>                                struct gprs_ns2_vc **success);</span><br><span>diff --git a/src/gb/gprs_ns2_udp.c b/src/gb/gprs_ns2_udp.c</span><br><span>index 3081680..5765c77 100644</span><br><span>--- a/src/gb/gprs_ns2_udp.c</span><br><span>+++ b/src/gb/gprs_ns2_udp.c</span><br><span>@@ -231,7 +231,7 @@</span><br><span>         nsvc = gprs_ns2_nsvc_by_sockaddr_bind(bind, &saddr);</span><br><span>     if (!nsvc) {</span><br><span>                 /* VC not found */</span><br><span style="color: hsl(0, 100%, 40%);">-              rc = ns2_create_vc(bind, msg, "newconnection", &reject, &nsvc);</span><br><span style="color: hsl(120, 100%, 40%);">+             rc = ns2_create_vc(bind, msg, &saddr, "newconnection", &reject, &nsvc);</span><br><span>                switch (rc) {</span><br><span>                case NS2_CS_FOUND:</span><br><span>                   break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/23224">change 23224</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/23224"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idf92712079cd9b7e4ff2cf8df314b372d63e6e52 </div>
<div style="display:none"> Gerrit-Change-Number: 23224 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>