<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/23161">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Threads: Avoid printing pthread_self()<br><br> The type used to represent a thread ID is implementation<br>specific, and may be an opaqe structure, making it unsuitable to be<br>printed by standard means. Let's use osmo_gettid() instead.<br><br>Change-Id: Iaa4d0eaf52b901fff06cc67f8dd8b61ac6084911<br>Related: OS#5032<br>---<br>M CommonLibs/Threads.cpp<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/CommonLibs/Threads.cpp b/CommonLibs/Threads.cpp</span><br><span>index a98183a..b6750ab 100644</span><br><span>--- a/CommonLibs/Threads.cpp</span><br><span>+++ b/CommonLibs/Threads.cpp</span><br><span>@@ -49,7 +49,7 @@</span><br><span> {</span><br><span>   gStreamLock.lock();</span><br><span>  Timeval entryTime;</span><br><span style="color: hsl(0, 100%, 40%);">-      cout << entryTime << " " << pthread_self() << ": ";</span><br><span style="color: hsl(120, 100%, 40%);">+       cout << entryTime << " " << osmo_gettid() << ": ";</span><br><span> }</span><br><span> </span><br><span> </span><br><span>@@ -64,7 +64,7 @@</span><br><span> {</span><br><span>         gStreamLock.lock();</span><br><span>  Timeval entryTime;</span><br><span style="color: hsl(0, 100%, 40%);">-      cerr << entryTime << " " << pthread_self() << ": ";</span><br><span style="color: hsl(120, 100%, 40%);">+       cerr << entryTime << " " << osmo_gettid() << ": ";</span><br><span> }</span><br><span> </span><br><span> void unlockCerr()</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/23161">change 23161</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/23161"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaa4d0eaf52b901fff06cc67f8dd8b61ac6084911 </div>
<div style="display:none"> Gerrit-Change-Number: 23161 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>