<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23126">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">msc: Get rid of several uneeded module params<br><br>These params are not needed anymore since new releases used in -latest don't<br>need to disable it.<br><br>Change-Id: I16575ae4f615bf7c42d5921917003007ba4872a0<br>Related: OS#5042<br>---<br>M msc/BSC_ConnectionHandler.ttcn<br>M msc/MSC_Tests.ttcn<br>2 files changed, 4 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/23126/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/msc/BSC_ConnectionHandler.ttcn b/msc/BSC_ConnectionHandler.ttcn</span><br><span>index 3996a87..30adb03 100644</span><br><span>--- a/msc/BSC_ConnectionHandler.ttcn</span><br><span>+++ b/msc/BSC_ConnectionHandler.ttcn</span><br><span>@@ -62,10 +62,6 @@</span><br><span> </span><br><span> import from TCCConversion_Functions { function f_strstr };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-modulepar {</span><br><span style="color: hsl(0, 100%, 40%);">-   boolean mp_expect_common_id := true;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /* this component represents a single subscriber connection */</span><br><span> type component BSC_ConnHdlr extends RAN_ConnHdlr, MNCC_ConnHdlr, GSUP_ConnHdlr, MGCP_ConnHdlr, SMPP_ConnHdlr, CTRL_Adapter_CT, SGsAP_ConnHdlr {</span><br><span>   var BSC_ConnHdlrPars g_pars;</span><br><span>@@ -528,9 +524,7 @@</span><br><span> function f_expect_common_id() runs on BSC_ConnHdlr</span><br><span> {</span><br><span>        if (g_pars.ran_is_geran) {</span><br><span style="color: hsl(0, 100%, 40%);">-              if (mp_expect_common_id) {</span><br><span style="color: hsl(0, 100%, 40%);">-                      BSSAP.receive(tr_BSSMAP_CommonId(g_pars.imsi));</span><br><span style="color: hsl(0, 100%, 40%);">-         }</span><br><span style="color: hsl(120, 100%, 40%);">+             BSSAP.receive(tr_BSSMAP_CommonId(g_pars.imsi));</span><br><span>      } else {</span><br><span>             BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi)));</span><br><span>         }</span><br><span>diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn</span><br><span>index 6bad9c3..7a54e17 100644</span><br><span>--- a/msc/MSC_Tests.ttcn</span><br><span>+++ b/msc/MSC_Tests.ttcn</span><br><span>@@ -162,10 +162,6 @@</span><br><span>                        rctx := 1</span><br><span>            }</span><br><span>    };</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-      boolean mp_enable_cell_id_test := true;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- boolean mp_enable_crashing_tests := true;</span><br><span> }</span><br><span> </span><br><span> /* altstep for the global guard timer (only used when BSSAP_DIRECT</span><br><span>@@ -404,7 +400,7 @@</span><br><span>               ran_is_geran := ran_is_geran,</span><br><span>                use_osmux := use_osmux,</span><br><span>              use_ipv6 := false,</span><br><span style="color: hsl(0, 100%, 40%);">-              verify_cell_id := mp_enable_cell_id_test and verify_cell_id</span><br><span style="color: hsl(120, 100%, 40%);">+           verify_cell_id := verify_cell_id</span><br><span>     };</span><br><span>   if (not ran_is_geran) {</span><br><span>              pars.use_umts_aka := true;</span><br><span>@@ -6534,10 +6530,8 @@</span><br><span>  execute( TC_invalid_mgcp_crash() );</span><br><span>  execute( TC_mm_id_resp_no_identity() );</span><br><span>      execute( TC_lu_and_expire_while_paging() );</span><br><span style="color: hsl(0, 100%, 40%);">-     if (mp_enable_crashing_tests) {</span><br><span style="color: hsl(0, 100%, 40%);">-         execute( TC_paging_response_imsi_unknown() );</span><br><span style="color: hsl(0, 100%, 40%);">-           execute( TC_paging_response_tmsi_unknown() );</span><br><span style="color: hsl(0, 100%, 40%);">-   }</span><br><span style="color: hsl(120, 100%, 40%);">+     execute( TC_paging_response_imsi_unknown() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_paging_response_tmsi_unknown() );</span><br><span> }</span><br><span> </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23126">change 23126</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23126"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16575ae4f615bf7c42d5921917003007ba4872a0 </div>
<div style="display:none"> Gerrit-Change-Number: 23126 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>