<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23128">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">BSSGP+pcu: Get rid of mp_tolerate_bvc_reset_cellid<br><br>Since we have new releases in -latest, we don't need this param since<br>it's never set to true.<br><br>Related: OS~5042<br>Change-Id: Ic496407fd2139b3a5221c30f1798797320cdee24<br>---<br>M library/BSSGP_Emulation.ttcnpp<br>M pcu/PCU_Tests_NS.ttcn<br>2 files changed, 1 insertion(+), 26 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/28/23128/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp</span><br><span>index 1f32cc2..593abd8 100644</span><br><span>--- a/library/BSSGP_Emulation.ttcnpp</span><br><span>+++ b/library/BSSGP_Emulation.ttcnpp</span><br><span>@@ -37,12 +37,6 @@</span><br><span> </span><br><span> import from SNDCP_Types all;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-modulepar {</span><br><span style="color: hsl(0, 100%, 40%);">- /* tolerate CellID absence/presence in BVC-RESET in violation to spec */</span><br><span style="color: hsl(0, 100%, 40%);">-        boolean mp_tolerate_bvc_reset_cellid := false;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> /***********************************************************************</span><br><span>  * Communication between Client Components and per-BVC component</span><br><span>  ***********************************************************************/</span><br><span>@@ -292,16 +286,6 @@</span><br><span>          }</span><br><span>            BSCP.send(f_BnsUdReq(ts_BVC_RESET_ACK(0, omit), 0, 0));</span><br><span>      }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-       /* work-around for old, buggy libosmogb before Change-Id Ie87820537d6d616da4fd4bbf73eab06e28fda5e1 */</span><br><span style="color: hsl(0, 100%, 40%);">-   [mp_tolerate_bvc_reset_cellid] BSCP.receive(f_BnsUdInd(tr_BVC_RESET(?, 0, g_cfg.bvc[0].cell_id), 0)) -> value udi {</span><br><span style="color: hsl(0, 100%, 40%);">-          log("Rx BVC-RESET for Signaling BVCI=0");</span><br><span style="color: hsl(0, 100%, 40%);">-             f_sign_change_state(BVC_S_UNBLOCKED);</span><br><span style="color: hsl(0, 100%, 40%);">-           if (MGMT.checkstate("Connected")) {</span><br><span style="color: hsl(0, 100%, 40%);">-                   MGMT.send(BssgpResetIndication:{0});</span><br><span style="color: hsl(0, 100%, 40%);">-            }</span><br><span style="color: hsl(0, 100%, 40%);">-               BSCP.send(f_BnsUdReq(ts_BVC_RESET_ACK(0, omit), 0, 0));</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span> }</span><br><span> </span><br><span> private template PDU_BSSGP tr_GLOBAL_SIG := (</span><br><span>diff --git a/pcu/PCU_Tests_NS.ttcn b/pcu/PCU_Tests_NS.ttcn</span><br><span>index 9cf37b5..e2bad4f 100644</span><br><span>--- a/pcu/PCU_Tests_NS.ttcn</span><br><span>+++ b/pcu/PCU_Tests_NS.ttcn</span><br><span>@@ -25,11 +25,6 @@</span><br><span> import from PCUIF_CodecPort all;</span><br><span> import from RAW_NS all;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-modulepar {</span><br><span style="color: hsl(0, 100%, 40%);">- /* tolerate CellID absence/presence in BVC-RESET in violation to spec */</span><br><span style="color: hsl(0, 100%, 40%);">-        boolean mp_tolerate_bvc_reset_cellid := false;</span><br><span style="color: hsl(0, 100%, 40%);">-}</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> type component RAW_PCU_CT {</span><br><span>       /* PCUIF (we emulate the BTS part) */</span><br><span>        port PCUIF_CODEC_PT PCU;</span><br><span>@@ -197,11 +192,7 @@</span><br><span>      f_outgoing_ns_alive();</span><br><span> </span><br><span>   /* Expect BVC-RESET for signaling (0) and ptp BVCI */</span><br><span style="color: hsl(0, 100%, 40%);">-   if (mp_tolerate_bvc_reset_cellid) {</span><br><span style="color: hsl(0, 100%, 40%);">-             as_rx_bvc_reset_tx_ack(0, mp_gb_cfg.bvc[0].cell_id, omit, oneshot := true);</span><br><span style="color: hsl(0, 100%, 40%);">-     } else {</span><br><span style="color: hsl(0, 100%, 40%);">-                as_rx_bvc_reset_tx_ack(0, omit, omit, oneshot := true);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+     as_rx_bvc_reset_tx_ack(0, omit, omit, oneshot := true);</span><br><span>      as_rx_bvc_reset_tx_ack(mp_gb_cfg.bvc[0].bvci, mp_gb_cfg.bvc[0].cell_id, omit, oneshot := true);</span><br><span>      as_rx_bvc_unblock_tx_ack(mp_gb_cfg.bvc[0].bvci, oneshot := true);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23128">change 23128</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23128"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic496407fd2139b3a5221c30f1798797320cdee24 </div>
<div style="display:none"> Gerrit-Change-Number: 23128 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>