<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23120">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hlr: Get rid of module param mp_hlr_supports_dgsm<br><br>This param is not needed anymore since new releases used in -latest don't<br>need to disable it.<br><br>Change-Id: I484267c169646310564bd6d9cd13a196b61400e4<br>Related: OS#5042<br>---<br>M hlr/HLR_Tests.cfg<br>M hlr/HLR_Tests.ttcn<br>2 files changed, 6 insertions(+), 14 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/20/23120/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/hlr/HLR_Tests.cfg b/hlr/HLR_Tests.cfg</span><br><span>index 1ab6e87..7416362 100644</span><br><span>--- a/hlr/HLR_Tests.cfg</span><br><span>+++ b/hlr/HLR_Tests.cfg</span><br><span>@@ -12,7 +12,6 @@</span><br><span> </span><br><span> </span><br><span> [MODULE_PARAMETERS]</span><br><span style="color: hsl(0, 100%, 40%);">-HLR_Tests.mp_hlr_supports_dgsm := true</span><br><span> </span><br><span> [MAIN_CONTROLLER]</span><br><span> </span><br><span>diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn</span><br><span>index ea450b3..959c680 100644</span><br><span>--- a/hlr/HLR_Tests.ttcn</span><br><span>+++ b/hlr/HLR_Tests.ttcn</span><br><span>@@ -70,9 +70,6 @@</span><br><span>       /* emulated GSUP server (second HLR) */</span><br><span>      charstring mp_hlr_ts_ip := "127.0.0.99";</span><br><span>   integer mp_hlr_ts_port := 4222;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* drop after osmo-hlr release > 1.2.0 */</span><br><span style="color: hsl(0, 100%, 40%);">-    boolean mp_hlr_supports_dgsm := true;</span><br><span> };</span><br><span> </span><br><span> type record HlrSubscrAud2G {</span><br><span>@@ -154,9 +151,7 @@</span><br><span>        map(self:VTY, system:VTY);</span><br><span>   f_vty_set_prompts(VTY);</span><br><span>      f_vty_transceive(VTY, "enable");</span><br><span style="color: hsl(0, 100%, 40%);">-      if (mp_hlr_supports_dgsm) {</span><br><span style="color: hsl(0, 100%, 40%);">-             f_vty_config(VTY, "mslookup", "no mdns bind");</span><br><span style="color: hsl(0, 100%, 40%);">-      }</span><br><span style="color: hsl(120, 100%, 40%);">+     f_vty_config(VTY, "mslookup", "no mdns bind");</span><br><span> }</span><br><span> </span><br><span> private altstep as_Tguard() runs on test_CT {</span><br><span>@@ -1973,13 +1968,11 @@</span><br><span>       execute( TC_subscr_create_on_demand_ul() );</span><br><span>  execute( TC_subscr_create_on_demand_sai() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        if (mp_hlr_supports_dgsm) {</span><br><span style="color: hsl(0, 100%, 40%);">-             execute( TC_MSLookup_mDNS_service_other_home() );</span><br><span style="color: hsl(0, 100%, 40%);">-               execute( TC_MSLookup_GSUP_proxy() );</span><br><span style="color: hsl(0, 100%, 40%);">-            execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() );</span><br><span style="color: hsl(0, 100%, 40%);">-            execute( TC_MSLookup_mDNS_service_GSUP_HLR_proxy() );</span><br><span style="color: hsl(0, 100%, 40%);">-           execute( TC_MSLookup_mDNS_service_other_proxy() );</span><br><span style="color: hsl(0, 100%, 40%);">-      }</span><br><span style="color: hsl(120, 100%, 40%);">+     execute( TC_MSLookup_mDNS_service_other_home() );</span><br><span style="color: hsl(120, 100%, 40%);">+     execute( TC_MSLookup_GSUP_proxy() );</span><br><span style="color: hsl(120, 100%, 40%);">+  execute( TC_MSLookup_mDNS_service_GSUP_HLR_home() );</span><br><span style="color: hsl(120, 100%, 40%);">+  execute( TC_MSLookup_mDNS_service_GSUP_HLR_proxy() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_MSLookup_mDNS_service_other_proxy() );</span><br><span> };</span><br><span> </span><br><span> };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23120">change 23120</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23120"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I484267c169646310564bd6d9cd13a196b61400e4 </div>
<div style="display:none"> Gerrit-Change-Number: 23120 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>