<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23113">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">StatsD_Checker: Enable by default<br><br>It was previously disabled by default in order to avoid test breakage<br>with older versions of osmocom projects not supporting them. Since we<br>just did a new release, all -latest contian now master which should work<br>fine.<br><br>Don't remove the moduleparam yet in order to avoid breakage with some<br>cfg files in docker-playground.git still setting it to true.<br><br>Related: OS#5042<br>Change-Id: I4e2049c109986906d3c985ca2282174b1abff581<br>---<br>M bsc/BSC_Tests.default<br>M library/StatsD_Checker.ttcn<br>M ns/NS_Tests.default<br>M pcu/PCU_Tests.default<br>4 files changed, 1 insertion(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.default b/bsc/BSC_Tests.default</span><br><span>index c5d1559..50c5c0a 100644</span><br><span>--- a/bsc/BSC_Tests.default</span><br><span>+++ b/bsc/BSC_Tests.default</span><br><span>@@ -29,6 +29,5 @@</span><br><span> </span><br><span> [MODULE_PARAMETERS]</span><br><span> Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoBSC";</span><br><span style="color: hsl(0, 100%, 40%);">-StatsD_Checker.mp_enable_stats := true;</span><br><span> </span><br><span> [EXECUTE]</span><br><span>diff --git a/library/StatsD_Checker.ttcn b/library/StatsD_Checker.ttcn</span><br><span>index 540e479..1c8fd12 100644</span><br><span>--- a/library/StatsD_Checker.ttcn</span><br><span>+++ b/library/StatsD_Checker.ttcn</span><br><span>@@ -38,7 +38,7 @@</span><br><span> </span><br><span> modulepar {</span><br><span>     /* Whether to test stats values */</span><br><span style="color: hsl(0, 100%, 40%);">-      boolean mp_enable_stats := false;</span><br><span style="color: hsl(120, 100%, 40%);">+     boolean mp_enable_stats := true;</span><br><span> }</span><br><span> </span><br><span> type record StatsDExpect {</span><br><span>diff --git a/ns/NS_Tests.default b/ns/NS_Tests.default</span><br><span>index 951c1c2..1c61bec 100644</span><br><span>--- a/ns/NS_Tests.default</span><br><span>+++ b/ns/NS_Tests.default</span><br><span>@@ -8,7 +8,6 @@</span><br><span> </span><br><span> [MODULE_PARAMETERS]</span><br><span> Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoNSdummy";</span><br><span style="color: hsl(0, 100%, 40%);">-StatsD_Checker.mp_enable_stats := true;</span><br><span> </span><br><span> [TESTPORT_PARAMETERS]</span><br><span> *.NSVTY.CTRL_MODE := "client"</span><br><span>diff --git a/pcu/PCU_Tests.default b/pcu/PCU_Tests.default</span><br><span>index 4d6c0a2..6f633d2 100644</span><br><span>--- a/pcu/PCU_Tests.default</span><br><span>+++ b/pcu/PCU_Tests.default</span><br><span>@@ -30,7 +30,6 @@</span><br><span> };</span><br><span> Osmocom_VTY_Functions.mp_prompt_prefix := "OsmoPCU";</span><br><span> PCUIF_Types.mp_pcuif_version := 10;</span><br><span style="color: hsl(0, 100%, 40%);">-StatsD_Checker.mp_enable_stats := true;</span><br><span> </span><br><span> [TESTPORT_PARAMETERS]</span><br><span> *.PCU.socket_type := "SEQPACKET"</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23113">change 23113</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23113"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4e2049c109986906d3c985ca2282174b1abff581 </div>
<div style="display:none"> Gerrit-Change-Number: 23113 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>