<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-smlc/+/23094">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">main: Support setting cmdline --vty-ref-mode<br><br>Change-Id: Iadb004319514cb134b0863ea16b3289e6f1a097a<br>---<br>M src/osmo-smlc/smlc_main.c<br>1 file changed, 29 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-smlc/smlc_main.c b/src/osmo-smlc/smlc_main.c</span><br><span>index 105ced3..3f24a42 100644</span><br><span>--- a/src/osmo-smlc/smlc_main.c</span><br><span>+++ b/src/osmo-smlc/smlc_main.c</span><br><span>@@ -78,6 +78,31 @@</span><br><span>      printf("  --vty-ref-xml                    Generate the VTY reference XML output and exit.\n");</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+static void handle_long_options(const char *prog_name, const int long_option)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+  static int vty_ref_mode = VTY_REF_GEN_MODE_DEFAULT;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (long_option) {</span><br><span style="color: hsl(120, 100%, 40%);">+        case 1:</span><br><span style="color: hsl(120, 100%, 40%);">+               vty_ref_mode = get_string_value(vty_ref_gen_mode_names, optarg);</span><br><span style="color: hsl(120, 100%, 40%);">+              if (vty_ref_mode < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    fprintf(stderr, "%s: Unknown VTY reference generation "</span><br><span style="color: hsl(120, 100%, 40%);">+                             "mode '%s'\n", prog_name, optarg);</span><br><span style="color: hsl(120, 100%, 40%);">+                  exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+              }</span><br><span style="color: hsl(120, 100%, 40%);">+             break;</span><br><span style="color: hsl(120, 100%, 40%);">+        case 2:</span><br><span style="color: hsl(120, 100%, 40%);">+               fprintf(stderr, "Generating the VTY reference in mode '%s' (%s)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                 get_value_string(vty_ref_gen_mode_names, vty_ref_mode),</span><br><span style="color: hsl(120, 100%, 40%);">+                       get_value_string(vty_ref_gen_mode_desc, vty_ref_mode));</span><br><span style="color: hsl(120, 100%, 40%);">+               vty_dump_xml_ref_mode(stdout, (enum vty_ref_gen_mode) vty_ref_mode);</span><br><span style="color: hsl(120, 100%, 40%);">+          exit(0);</span><br><span style="color: hsl(120, 100%, 40%);">+      default:</span><br><span style="color: hsl(120, 100%, 40%);">+              fprintf(stderr, "%s: error parsing cmdline options\n", prog_name);</span><br><span style="color: hsl(120, 100%, 40%);">+          exit(2);</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void handle_options(int argc, char **argv)</span><br><span> {</span><br><span>     while (1) {</span><br><span>@@ -90,7 +115,8 @@</span><br><span>                     {"config-file", 1, 0, 'c'},</span><br><span>                        {"version", 0, 0, 'V' },</span><br><span>                   {"log-level", 1, 0, 'e'},</span><br><span style="color: hsl(0, 100%, 40%);">-                     {"vty-ref-xml", 0, &long_option, 1},</span><br><span style="color: hsl(120, 100%, 40%);">+                    {"vty-ref-mode", 1, &long_option, 1},</span><br><span style="color: hsl(120, 100%, 40%);">+                   {"vty-ref-xml", 0, &long_option, 2},</span><br><span>                   {0, 0, 0, 0}</span><br><span>                 };</span><br><span> </span><br><span>@@ -105,14 +131,8 @@</span><br><span>                        print_help();</span><br><span>                        exit(0);</span><br><span>             case 0:</span><br><span style="color: hsl(0, 100%, 40%);">-                 switch (long_option) {</span><br><span style="color: hsl(0, 100%, 40%);">-                  case 1:</span><br><span style="color: hsl(0, 100%, 40%);">-                         vty_dump_xml_ref(stdout);</span><br><span style="color: hsl(0, 100%, 40%);">-                               exit(0);</span><br><span style="color: hsl(0, 100%, 40%);">-                        default:</span><br><span style="color: hsl(0, 100%, 40%);">-                                fprintf(stderr, "error parsing cmdline options\n");</span><br><span style="color: hsl(0, 100%, 40%);">-                           exit(2);</span><br><span style="color: hsl(0, 100%, 40%);">-                        }</span><br><span style="color: hsl(120, 100%, 40%);">+                     handle_long_options(argv[0], long_option);</span><br><span style="color: hsl(120, 100%, 40%);">+                    break;</span><br><span>               case 'd':</span><br><span>                    log_parse_category_mask(osmo_stderr_target, optarg);</span><br><span>                         break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-smlc/+/23094">change 23094</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-smlc/+/23094"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-smlc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iadb004319514cb134b0863ea16b3289e6f1a097a </div>
<div style="display:none"> Gerrit-Change-Number: 23094 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>