<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/23029">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">serial: don't crash if the device does not exist<br><br>The most common reason for pySim to crash is when it is executed without<br>commandline parameters. Then pySim will expect a serial reader on<br>/dev/ttyUSB0 since this is the default. Lets check if /dev/ttyUSB0 even<br>exists before trying to open it.<br><br>Change-Id: I7545c728b531e9a796eee8f80f0b08d4097f8399<br>---<br>M pySim/transport/serial.py<br>1 file changed, 3 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/transport/serial.py b/pySim/transport/serial.py</span><br><span>index 61195e0..b841b3e 100644</span><br><span>--- a/pySim/transport/serial.py</span><br><span>+++ b/pySim/transport/serial.py</span><br><span>@@ -25,6 +25,7 @@</span><br><span> </span><br><span> import serial</span><br><span> import time</span><br><span style="color: hsl(120, 100%, 40%);">+import os.path</span><br><span> </span><br><span> from pySim.exceptions import NoCardError, ProtocolError</span><br><span> from pySim.transport import LinkBase</span><br><span>@@ -34,6 +35,8 @@</span><br><span> class SerialSimLink(LinkBase):</span><br><span> </span><br><span>         def __init__(self, device='/dev/ttyUSB0', baudrate=9600, rst='-rts', debug=False):</span><br><span style="color: hsl(120, 100%, 40%);">+            if not os.path.exists(device):</span><br><span style="color: hsl(120, 100%, 40%);">+                        raise ValueError("device file %s does not exist -- abort" % device)</span><br><span>                self._sl = serial.Serial(</span><br><span>                            port = device,</span><br><span>                               parity = serial.PARITY_EVEN,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23029">change 23029</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23029"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7545c728b531e9a796eee8f80f0b08d4097f8399 </div>
<div style="display:none"> Gerrit-Change-Number: 23029 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>