<p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23053">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-bsc-test/jenkins.sh">File ttcn3-bsc-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-bsc-test/jenkins.sh@a24">Patch Set #1, Line 24:</a> <code style="font-family:monospace,monospace">pre-mscpool-osmo-bsc.cfg</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This file can be removed now.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-fr-test/jenkins.sh">File ttcn3-fr-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-fr-test/jenkins.sh@a20">Patch Set #1, Line 20:</a> <code style="font-family:monospace,monospace"># Disable features not in latest yet</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I would keep this block empty everywhere instead of removing it completely. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't have a strong opinion about this. But if we remove it, we keep the boilderplate in each jenkins.sh lower (and such things tend to get inconsistent). Instead we could add an example to README for future reference.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-sgsn-test/jenkins.sh">File ttcn3-sgsn-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23053/1/ttcn3-sgsn-test/jenkins.sh@a27">Patch Set #1, Line 27:</a> <code style="font-family:monospace,monospace">    cp  osmo-sgsn.latest.cfg "$VOL_BASE_DIR/sgsn/osmo-sgsn.cfg"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This file can be removed now.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/23053">change 23053</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/23053"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f491b58d4576b22c8ff3ab56a7b9e17163a8739 </div>
<div style="display:none"> Gerrit-Change-Number: 23053 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 25 Feb 2021 11:23:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>