<p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/osmo-ggsn-latest/Dockerfile">File osmo-ggsn-latest/Dockerfile:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/osmo-ggsn-latest/Dockerfile@22">Patch Set #3, Line 22:</a> <code style="font-family:monospace,monospace">RUN      ln -s /bin/true /usr/local/bin/update-initramfs && \</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Some description about this would be welcome</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/scripts/kernel-test/qemu-ifup.sh">File scripts/kernel-test/qemu-ifup.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/scripts/kernel-test/qemu-ifup.sh@5">Patch Set #3, Line 5:</a> <code style="font-family:monospace,monospace">echo "[host] qemu-ifup: $br, $1, $docker_if"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">maybe store $1 to some variable explaining the name instead of using $1 several times.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/scripts/kernel-test/qemu-ifup.sh@11">Patch Set #3, Line 11:</a> <code style="font-family:monospace,monospace">ethtool -K $br gro off gso off tso off tx off rx off sg off >/dev/null 2>&1</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think we need the ethtool lines here and below.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/initrd-ggsn.sh">File ttcn3-ggsn-test/initrd-ggsn.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/initrd-ggsn.sh@18">Patch Set #3, Line 18:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not sure what do we win by creating a separate initrd instead of simply sharing the docker rootfs inside the qemu env (security?), but fine.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/jenkins.sh">File ttcn3-ggsn-test/jenkins.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/docker-playground/+/23005/3/ttcn3-ggsn-test/jenkins.sh@24">Patch Set #3, Line 24:</a> <code style="font-family:monospace,monospace">cp osmo-ggsn.cfg $VOL_BASE_DIR/ggsn/</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This line can be moved to the else condition below.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/23005">change 23005</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/23005"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I54e752048eed2a170a1cf4e0fd410de255b9de5d </div>
<div style="display:none"> Gerrit-Change-Number: 23005 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 22 Feb 2021 10:02:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>