<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23012">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">PCU_Tests: make use of GprsMS in TC_ta_idle_dl_tbf_ass()<br><br>Change-Id: Ife9cea132f47c528702e653ac061fa3851090a24<br>---<br>M pcu/PCU_Tests.ttcn<br>1 file changed, 5 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn</span><br><span>index 5ab208b..1d35a55 100644</span><br><span>--- a/pcu/PCU_Tests.ttcn</span><br><span>+++ b/pcu/PCU_Tests.ttcn</span><br><span>@@ -501,8 +501,7 @@</span><br><span>  * IUT that causes it to send an unreasonable Timing Advance value > 0 despite</span><br><span>  * no active TBF exists at the moment of establishment (idle mode). */</span><br><span> testcase TC_ta_idle_dl_tbf_ass() runs on RAW_PCU_Test_CT {</span><br><span style="color: hsl(0, 100%, 40%);">-   var OCT4 tlli := f_rnd_octstring(4);</span><br><span style="color: hsl(0, 100%, 40%);">-    var GsmRrMessage rr_imm_ass;</span><br><span style="color: hsl(120, 100%, 40%);">+  var GprsMS ms := valueof(t_GprsMS_def);</span><br><span> </span><br><span>  /* Initialize NS/BSSGP side */</span><br><span>       f_init_bssgp();</span><br><span>@@ -512,17 +511,17 @@</span><br><span> </span><br><span>  /* Establish BSSGP connection to the PCU */</span><br><span>  f_bssgp_establish();</span><br><span style="color: hsl(0, 100%, 40%);">-    f_bssgp_client_llgmm_assign(TLLI_UNUSED, tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+       f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli);</span><br><span> </span><br><span>       /* SGSN sends some DL data, PCU will initiate Packet Downlink</span><br><span>         * Assignment on CCCH (PCH). We don't care about the payload. */</span><br><span style="color: hsl(0, 100%, 40%);">-    BSSGP[0].send(ts_BSSGP_DL_UD(tlli, f_rnd_octstring(10)));</span><br><span style="color: hsl(0, 100%, 40%);">-       rr_imm_ass := f_pcuif_rx_imm_ass(PCU_IF_SAPI_PCH, tr_IMM_TBF_ASS(dl := true));</span><br><span style="color: hsl(120, 100%, 40%);">+        BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, f_rnd_octstring(10)));</span><br><span style="color: hsl(120, 100%, 40%);">+  f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH);</span><br><span> </span><br><span>   /* Make sure that Timing Advance is 0 (the actual value is not known yet).</span><br><span>    * As per 3GPP S 44.018, section 3.5.3.1.2, the network *shall* initiate</span><br><span>      * the procedures defined in 3GPP TS 44.060 or use the polling mechanism. */</span><br><span style="color: hsl(0, 100%, 40%);">-    if (rr_imm_ass.payload.imm_ass.timing_advance != 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (ms.dl_tbf.rr_imm_ass.payload.imm_ass.timing_advance != 0) {</span><br><span>              setverdict(fail, "Timing Advance value doesn't match");</span><br><span>        }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23012">change 23012</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/23012"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ife9cea132f47c528702e653ac061fa3851090a24 </div>
<div style="display:none"> Gerrit-Change-Number: 23012 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>