<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22997">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">find_multi_slots: Avoid multiple calls to mslot_class_get_type()<br><br>Change-Id: I9cda52befe32a7727ab479bc151d10106fb94688<br>---<br>M src/gprs_rlcmac_ts_alloc.cpp<br>1 file changed, 4 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_rlcmac_ts_alloc.cpp b/src/gprs_rlcmac_ts_alloc.cpp</span><br><span>index cb054cd..5f0bcc5 100644</span><br><span>--- a/src/gprs_rlcmac_ts_alloc.cpp</span><br><span>+++ b/src/gprs_rlcmac_ts_alloc.cpp</span><br><span>@@ -518,7 +518,8 @@</span><br><span> {</span><br><span>      const uint8_t Rx = mslot_class_get_rx(mslot_class),   /* Max number of Rx slots */</span><br><span>                 Tx = mslot_class_get_tx(mslot_class),   /* Max number of Tx slots */</span><br><span style="color: hsl(0, 100%, 40%);">-                    Sum = mslot_class_get_sum(mslot_class); /* Max number of Tx + Rx slots */</span><br><span style="color: hsl(120, 100%, 40%);">+                     Sum = mslot_class_get_sum(mslot_class), /* Max number of Tx + Rx slots */</span><br><span style="color: hsl(120, 100%, 40%);">+                     Type = mslot_class_get_type(mslot_class);</span><br><span>      uint8_t max_slots, num_rx, num_tx, mask_sel, pdch_slots, ul_ts, dl_ts;</span><br><span>       int16_t rx_window, tx_window;</span><br><span>        char slot_info[9] = {0};</span><br><span>@@ -574,7 +575,7 @@</span><br><span>                       /* for multislot type 1: don't split the window to wrap around.</span><br><span>                   * E.g. 'UU-----U' is invalid for a 4 TN window. Except 8 TN window.</span><br><span>                          * See 45.002 B.1 */</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (mslot_class_get_type(mslot_class) == 1 && num_tx < 8 &&</span><br><span style="color: hsl(120, 100%, 40%);">+                        if (Type == 1 && num_tx < 8 &&</span><br><span>                                    tx_valid_win & (1 << 0) && tx_valid_win & (1 << 7))</span><br><span>                              continue;</span><br><span> </span><br><span>@@ -602,7 +603,7 @@</span><br><span>                          /* for multislot type 1: don't split the window to wrap around.</span><br><span>                           * E.g. 'DD-----D' is invalid for a 4 TN window. Except 8 TN window.</span><br><span>                                  * See 45.002 B.1 */</span><br><span style="color: hsl(0, 100%, 40%);">-                            if (mslot_class_get_type(mslot_class) == 1 && num_rx < 8 &&</span><br><span style="color: hsl(120, 100%, 40%);">+                                if (Type == 1 && num_rx < 8 &&</span><br><span>                                            (rx_valid_win & (1 << 0)) && (rx_valid_win & (1 << 7)))</span><br><span>                                  continue;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22997">change 22997</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22997"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9cda52befe32a7727ab479bc151d10106fb94688 </div>
<div style="display:none"> Gerrit-Change-Number: 22997 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>