<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22966">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2: free_nse: free the SNS fsm early<br><br>If the SNS fsm isn't freed early, the SNS code will re-create a NSVC<br>when calling free_nsvc().<br>Fixes libasan heap-use-after-free.<br><br>Change-Id: If350df1d8d6dcea5715dd23b8bd1d684098cdb1f<br>---<br>M src/gb/gprs_ns2.c<br>1 file changed, 5 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/22966/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c</span><br><span>index c48575b..a79dd05 100644</span><br><span>--- a/src/gb/gprs_ns2.c</span><br><span>+++ b/src/gb/gprs_ns2.c</span><br><span>@@ -831,12 +831,15 @@</span><br><span>              return;</span><br><span> </span><br><span>  nse->alive = false;</span><br><span style="color: hsl(120, 100%, 40%);">+        if (nse->bss_sns_fi) {</span><br><span style="color: hsl(120, 100%, 40%);">+             osmo_fsm_inst_term(nse->bss_sns_fi, OSMO_FSM_TERM_REQUEST, NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+          nse->bss_sns_fi = NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+    }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  gprs_ns2_free_nsvcs(nse);</span><br><span>    ns2_prim_status_ind(nse, NULL, 0, GPRS_NS2_AFF_CAUSE_FAILURE);</span><br><span> </span><br><span>   llist_del(&nse->list);</span><br><span style="color: hsl(0, 100%, 40%);">-   if (nse->bss_sns_fi)</span><br><span style="color: hsl(0, 100%, 40%);">-         osmo_fsm_inst_term(nse->bss_sns_fi, OSMO_FSM_TERM_REQUEST, NULL);</span><br><span>         talloc_free(nse);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22966">change 22966</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22966"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If350df1d8d6dcea5715dd23b8bd1d684098cdb1f </div>
<div style="display:none"> Gerrit-Change-Number: 22966 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>