<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22962">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/gb/gprs_ns_test.c">File tests/gb/gprs_ns_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/gb/gprs_ns_test.c@911">Patch Set #1, Line 911:</a> <code style="font-family:monospace,monospace">     osmo_signal_register_handler(SS_L_NS, &test_signal, NULL);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why moving this line?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/gsup/gsup_test.c">File tests/gsup/gsup_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/gsup/gsup_test.c@755">Patch Set #1, Line 755:</a> <code style="font-family:monospace,monospace">     log_set_print_category_hex(osmo_stderr_target, 0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">looks like a chunk belonging to the previous patch?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/oap/oap_client_test.c">File tests/oap/oap_client_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22962/1/tests/oap/oap_client_test.c@264">Patch Set #1, Line 264:</a> <code style="font-family:monospace,monospace">    log_set_print_category_hex(osmo_stderr_target, 0);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">also from previous patch?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22962">change 22962</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22962"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifc78e1dcba5baf0b41f6ccbbbd1e3f06552d73da </div>
<div style="display:none"> Gerrit-Change-Number: 22962 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 19 Feb 2021 07:20:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>