<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22957">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sched: Avoid selecting TBF to tx NACC Dl msg if no TFI is assigned<br><br>The DL NACC related message (PKT Cell Neighbor Data/Change Continue)<br>are filled with the TFI of the target TBF. Hence, only select the tbf<br>for NACC transmission if the related TBF already has a TFI assigned.<br><br>Related: SYS#4909<br>Change-Id: I72b2dff28aacdb04909c098c94834ff79f55b31d<br>---<br>M src/gprs_rlcmac_sched.cpp<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/57/22957/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_rlcmac_sched.cpp b/src/gprs_rlcmac_sched.cpp</span><br><span>index b95d779..eaea406 100644</span><br><span>--- a/src/gprs_rlcmac_sched.cpp</span><br><span>+++ b/src/gprs_rlcmac_sched.cpp</span><br><span>@@ -72,8 +72,8 @@</span><br><span>                 if (ul_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS)</span><br><span>              || ul_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS_REJ))</span><br><span>                  tbf_cand->ul_ass = ul_tbf;</span><br><span style="color: hsl(0, 100%, 40%);">-           /* NACC ready to send */</span><br><span style="color: hsl(0, 100%, 40%);">-                if (ms_nacc_rts(ul_tbf->ms()))</span><br><span style="color: hsl(120, 100%, 40%);">+             /* NACC ready to send. TFI assigned is needed to send messages */</span><br><span style="color: hsl(120, 100%, 40%);">+             if (ul_tbf->is_tfi_assigned() && ms_nacc_rts(ul_tbf->ms()))</span><br><span>                    tbf_cand->nacc = ul_tbf;</span><br><span> /* FIXME: Is this supposed to be fair? The last TBF for each wins? Maybe use llist_add_tail and skip once we have all</span><br><span> states? */</span><br><span>@@ -92,8 +92,8 @@</span><br><span>               if (dl_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS)</span><br><span>              || dl_tbf->ul_ass_state_is(GPRS_RLCMAC_UL_ASS_SEND_ASS_REJ))</span><br><span>                  tbf_cand->ul_ass = dl_tbf;</span><br><span style="color: hsl(0, 100%, 40%);">-           /* NACC ready to send */</span><br><span style="color: hsl(0, 100%, 40%);">-                if (ms_nacc_rts(dl_tbf->ms()))</span><br><span style="color: hsl(120, 100%, 40%);">+             /* NACC ready to send. TFI assigned is needed to send messages */</span><br><span style="color: hsl(120, 100%, 40%);">+             if (dl_tbf->is_tfi_assigned() && ms_nacc_rts(dl_tbf->ms()))</span><br><span>                    tbf_cand->nacc = dl_tbf;</span><br><span>  }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22957">change 22957</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22957"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I72b2dff28aacdb04909c098c94834ff79f55b31d </div>
<div style="display:none"> Gerrit-Change-Number: 22957 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>