<p style="white-space: pre-wrap; word-wrap: break-word;">Hi,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Much cleaner now I think. All switch()ing is now done within assignment_count().</p><p style="white-space: pre-wrap; word-wrap: break-word;">There is, however, a special case for BTS_CTR_ASSIGNMENT_NO_CHANNEL as chan_mode is not available in lchan but only in the unfulfilled request.</p><p style="white-space: pre-wrap; word-wrap: break-word;">-Michael</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22947">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c">File src/osmo-bsc/assignment_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22947/2/src/osmo-bsc/assignment_fsm.c@102">Patch Set #2, Line 102:</a> <code style="font-family:monospace,monospace">#define assignment_count_result(counter) do { \</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I would at least give it a try if you don't mind, I fear otherwise we are filling lots of code with  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Pushed in patchset 3.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/22947">change 22947</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/22947"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I73f4dab6edb0951180f2bbcfc352ff34de647679 </div>
<div style="display:none"> Gerrit-Change-Number: 22947 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: iedemam <michael@kapsulate.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 17 Feb 2021 15:18:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: iedemam <michael@kapsulate.com> </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>