<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22885">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: Introduce tests for several cell change related scenarios<br><br>Test TC_cell_change_different_ci_data provides test case for<br>fix in osmo-sgsn.git Change-Id I2c14e1d65575f54212924f7c5f0a2f4c1b76ec81<br><br>Related: SYS#4909<br>Change-Id: I2158685bf817d4bf064bb4d2ef5aa96ca252fe21<br>---<br>M sgsn/SGSN_Tests.ttcn<br>1 file changed, 151 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index 4e35144..c6e22cc 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -371,7 +371,7 @@</span><br><span> }</span><br><span> }</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">- g_gb[2].cfg := {</span><br><span style="color: hsl(120, 100%, 40%);">+ g_gb[2].cfg := { /* [2] configured to have same RAC as [1] */</span><br><span> nsei := 98,</span><br><span> sgsn_role := false,</span><br><span> bvc := {</span><br><span>@@ -381,7 +381,7 @@</span><br><span> ra_id := {</span><br><span> lai := {</span><br><span> mcc_mnc := mcc_mnc,</span><br><span style="color: hsl(0, 100%, 40%);">- lac := 13300</span><br><span style="color: hsl(120, 100%, 40%);">+ lac := 13200</span><br><span> },</span><br><span> rac := 0</span><br><span> },</span><br><span>@@ -844,11 +844,19 @@</span><br><span> GSUP.send(ts_GSUP_UL_RES(g_pars.imsi));</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-friend function f_gmm_attach(boolean umts_aka_challenge, boolean force_gsm_sres, integer ran_index := 0) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(0, 100%, 40%);">- var RoutingAreaIdentificationV old_ra := f_random_RAI();</span><br><span style="color: hsl(0, 100%, 40%);">- var template PDU_L3_MS_SGSN attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra, false, false, omit, omit);</span><br><span style="color: hsl(120, 100%, 40%);">+friend function f_gmm_attach(boolean umts_aka_challenge, boolean force_gsm_sres, integer ran_index := 0,</span><br><span style="color: hsl(120, 100%, 40%);">+ template (omit) RoutingAreaIdentificationV old_ra := omit) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var RoutingAreaIdentificationV old_ra_val;</span><br><span style="color: hsl(120, 100%, 40%);">+ var template PDU_L3_MS_SGSN attach_req;</span><br><span> var PDU_L3_SGSN_MS l3_mt;</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ if (istemplatekind(old_ra, "omit")) {</span><br><span style="color: hsl(120, 100%, 40%);">+ old_ra_val := f_random_RAI();</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ old_ra_val := valueof(old_ra);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ attach_req := ts_GMM_ATTACH_REQ(f_mi_get_lv(), old_ra_val, false, false, omit, omit);</span><br><span> /* indicate R99 capability of the MS to enable UMTS AKA in presence of</span><br><span> * 3G auth vectors */</span><br><span> attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B;</span><br><span>@@ -1612,12 +1620,12 @@</span><br><span> }</span><br><span> </span><br><span> /* Transceive given 'payload' as MO message from Gb -> OsmoSGSN -> GTP */</span><br><span style="color: hsl(0, 100%, 40%);">-private function f_gtpu_xceive_mo(inout PdpActPars apars, octetstring payload, integer ran_index := 0)</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_gtpu_xceive_mo(inout PdpActPars apars, octetstring payload, integer ran_index := 0, uint9_t n_u := 0)</span><br><span> runs on BSSGP_ConnHdlr {</span><br><span> /* Send PDU via SNDCP/LLC/BSSGP/NS via simulated MS/PCU to the SGSN */</span><br><span> var GtpPeer peer := valueof(ts_GtpPeerU(apars.sgsn_ip_u));</span><br><span> var PDU_SN sndcp := valueof(ts_SN_UD(apars.nsapi, payload));</span><br><span style="color: hsl(0, 100%, 40%);">- BSSGP[ran_index].send(ts_LLC_UI(enc_PDU_SN(sndcp), apars.sapi, '0'B, 0));</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[ran_index].send(ts_LLC_UI(enc_PDU_SN(sndcp), apars.sapi, '0'B, n_u));</span><br><span> /* Expect PDU via GTP from SGSN on simulated GGSN */</span><br><span> alt {</span><br><span> [] GTP.receive(tr_GTPU_GPDU(peer, apars.ggsn_tei_u, payload));</span><br><span>@@ -3230,6 +3238,137 @@</span><br><span> f_cleanup();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Test if the SGSN routes traffic to new cell after the MS attached to it */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_cell_change_different_rai_ci_attach(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* first perform regular attach */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gmm_attach(false, false, ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then activate PDP context */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_act(apars, ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then transceive a downlink PDU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now attach on different cell: */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_unregister(g_pars.imsi, BSSGP_PROC[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ g_pars.net.expect_auth := false;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gmm_attach(false, false, ran_index := 1, old_ra := f_cellid_to_RAI(g_pars.bssgp_cell_id[0]));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 1, n_u := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_cell_change_different_rai_ci_attach() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_cell_change_different_rai_ci_attach), testcasename(), g_gb, 68);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_cleanup();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Test if the SGSN routes traffic to new cell after the MS attached to it */</span><br><span style="color: hsl(120, 100%, 40%);">+/* Assumption: g_gb[1] and g_gb[2] configured with same RAC */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_cell_change_different_ci_attach(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_unregister(g_pars.imsi, BSSGP_PROC[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* first perform regular attach */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gmm_attach(false, false, ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then activate PDP context */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_act(apars, ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then transceive a downlink PDU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now attach on different cell: */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_unregister(g_pars.imsi, BSSGP_PROC[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[2]);</span><br><span style="color: hsl(120, 100%, 40%);">+ g_pars.net.expect_auth := false;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gmm_attach(false, false, ran_index := 2, old_ra := f_cellid_to_RAI(g_pars.bssgp_cell_id[1]));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 2, n_u := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_cell_change_different_ci_attach() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_cell_change_different_ci_attach), testcasename(), g_gb, 69);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_cleanup();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Test if the SGSN silently drops MO data message coming from new BVCI if RAC changed (eg. cell change) */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_cell_change_different_rai_ci_data(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* first perform regular attach */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gmm_attach(false, false, ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then activate PDP context */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_act(apars, ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then transceive a downlink PDU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Send some data over new bvci, it should be silently discarded since</span><br><span style="color: hsl(120, 100%, 40%);">+ * RAC changed and SGSN expects a RAU to occur in that case */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ var octetstring payload := f_rnd_octstring(200);</span><br><span style="color: hsl(120, 100%, 40%);">+ var PDU_SN sndcp := valueof(ts_SN_UD(apars.nsapi, payload));</span><br><span style="color: hsl(120, 100%, 40%);">+ BSSGP[1].send(ts_LLC_UI(enc_PDU_SN(sndcp), apars.sapi, '0'B, 1));</span><br><span style="color: hsl(120, 100%, 40%);">+ var GtpPeer peer := valueof(ts_GtpPeerU(apars.sgsn_ip_u));</span><br><span style="color: hsl(120, 100%, 40%);">+ timer T := 2.0;</span><br><span style="color: hsl(120, 100%, 40%);">+ T.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GTP.receive(tr_GTPU_GPDU(peer, apars.ggsn_tei_u, payload)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "Unexpected GTP message");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ [] T.timeout { setverdict(pass); }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Expect SGSN to continue routing DL data to last known NSEI+BVCI */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_unregister(g_pars.imsi, BSSGP_PROC[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_cell_change_different_rai_ci_data() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_cell_change_different_rai_ci_data), testcasename(), g_gb, 70);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_cleanup();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* Test if the SGSN routes traffic to new cell after the MS switched cell without re-attaching */</span><br><span style="color: hsl(120, 100%, 40%);">+/* Assumption: g_gb[1] and g_gb[2] configured with same RAC */</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_TC_cell_change_different_ci_data(charstring id) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+ var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_unregister(g_pars.imsi, BSSGP_PROC[0]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* first perform regular attach */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gmm_attach(false, false, ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then activate PDP context */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_act(apars, ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* then transceive a downlink PDU */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Now attach on different cell: */</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_unregister(g_pars.imsi, BSSGP_PROC[1]);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_bssgp_client_register(g_pars.imsi, g_pars.tlli, BSSGP_PROC[2]);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mo(apars, f_rnd_octstring(200), ran_index := 2, n_u := 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_gtpu_xceive_mt(apars, f_rnd_octstring(100), ran_index := 2);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+testcase TC_cell_change_different_ci_data() runs on test_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var BSSGP_ConnHdlr vc_conn;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn := f_start_handler(refers(f_TC_cell_change_different_ci_data), testcasename(), g_gb, 71);</span><br><span style="color: hsl(120, 100%, 40%);">+ vc_conn.done;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_cleanup();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> control {</span><br><span> execute( TC_attach() );</span><br><span> execute( TC_attach_mnc3() );</span><br><span>@@ -3294,6 +3433,11 @@</span><br><span> </span><br><span> execute( TC_bssgp_rim_single_report() );</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_cell_change_different_rai_ci_attach() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_cell_change_different_rai_ci_data() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_cell_change_different_ci_attach() );</span><br><span style="color: hsl(120, 100%, 40%);">+ execute( TC_cell_change_different_ci_data() );</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* At the end, may crash osmo-sgsn, see OS#3957, OS#4245 */</span><br><span> execute( TC_attach_req_id_req_ra_update() );</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22885">change 22885</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22885"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2158685bf817d4bf064bb4d2ef5aa96ca252fe21 </div>
<div style="display:none"> Gerrit-Change-Number: 22885 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>