<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22872">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c">File src/gb/gprs_ns2_sns.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@100">Patch Set #8, Line 100:</a> <code style="font-family:monospace,monospace">   { GPRS_SNS_EV_REQ_ADD_BIND,             "ADD_BIND"},</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">wrong indentation?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@125">Patch Set #8, Line 125:</a> <code style="font-family:monospace,monospace"> struct ns2_sns_bind *current_bind;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I wonder, if there's only 1 current bind, why do we need a list entry and not simply a pointer to the object? Or can there be several "current" ones? The naming is then a bit confusing Should it then be called "current_binds" then.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22872/8/src/gb/gprs_ns2_sns.c@790">Patch Set #8, Line 790:</a> <code style="font-family:monospace,monospace">                        bind = sbind->bind;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">bind bind bind</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22872">change 22872</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22872"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9ab8092bf286e7d90e92f5702a5404425e959c84 </div>
<div style="display:none"> Gerrit-Change-Number: 22872 </div>
<div style="display:none"> Gerrit-PatchSet: 9 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 16 Feb 2021 15:34:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>