<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22937">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: Fix regression regarding g_pars.bssgp.cell_id[] array overflow<br><br>This was introduced in I7d859fd710dba96eb9b46c428243281183e1be12<br>and caused Iu related TTCN3 tests to fail with:<br><br>SGSN_Tests.ttcn:771 Dynamic test case error: Index overflow in a value of type @SGSN_Tests.BssgpCellIds: The index is 3, but the value has only 3 elements.<br><br>Change-Id: Iaae0015f5e7c7eabc426add91b5de1b63bf6d9f6<br>---<br>M Common.cfg<br>M gbproxy/GBProxy_Tests.ttcn<br>M gbproxy/osmo-gbproxy.fr.cfg<br>M sgsn/SGSN_Tests.ttcn<br>4 files changed, 26 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/22937/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Common.cfg b/Common.cfg</span><br><span>index b8c76e6..8233f23 100644</span><br><span>--- a/Common.cfg</span><br><span>+++ b/Common.cfg</span><br><span>@@ -15,5 +15,5 @@</span><br><span> ConsoleMask := ERROR | WARNING | TESTCASE | USER | VERDICTOP;</span><br><span> </span><br><span> [EXTERNAL_COMMANDS]</span><br><span style="color: hsl(0, 100%, 40%);">-BeginTestCase := $TCPDUMP_START</span><br><span style="color: hsl(0, 100%, 40%);">-EndTestCase := $TCPDUMP_STOP</span><br><span style="color: hsl(120, 100%, 40%);">+#BeginTestCase := $TCPDUMP_START</span><br><span style="color: hsl(120, 100%, 40%);">+#EndTestCase := $TCPDUMP_STOP</span><br><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index f1e5c79..15ecf91 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -3362,6 +3362,16 @@</span><br><span> /* TODO: test case for UL-STATUS(PAGING-by-IMSI) after sending an actual PAGIN-by-IMSI in DL first */</span><br><span> </span><br><span> control {</span><br><span style="color: hsl(120, 100%, 40%);">+ for (var integer i:=0; i< 10000; i := i+1) {</span><br><span style="color: hsl(120, 100%, 40%);">+ var verdicttype v;</span><br><span style="color: hsl(120, 100%, 40%);">+ //v := execute( TC_bvc_reset_sig_from_sgsn() );</span><br><span style="color: hsl(120, 100%, 40%);">+ v := execute( TC_paging_ps_ptp_lac() );</span><br><span style="color: hsl(120, 100%, 40%);">+ if (v != pass) {</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span> execute( TC_BVC_bringup() );</span><br><span> execute( TC_ul_unitdata() );</span><br><span> execute( TC_dl_unitdata() );</span><br><span>@@ -3382,11 +3392,9 @@</span><br><span> execute( TC_bvc_reset_ptp_from_sgsn() );</span><br><span> execute( TC_bvc_reset_sig_from_sgsn() );</span><br><span> if (mp_enable_bss_load_sharing) {</span><br><span style="color: hsl(0, 100%, 40%);">- /* don't enable this by default, as we don't yet have any automatic test setup for FR with 4 NS-VC */</span><br><span> execute( TC_load_sharing_dl() );</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* PAGING-PS over PTP BVC */</span><br><span> execute( TC_paging_ps_ptp_bss() );</span><br><span> execute( TC_paging_ps_ptp_lac() );</span><br><span> execute( TC_paging_ps_ptp_lac_unknown() );</span><br><span>@@ -3399,7 +3407,6 @@</span><br><span> execute( TC_paging_ps_reject_ptp_bvci_imsi() );</span><br><span> execute( TC_dummy_paging_ps_ptp() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* PAGING-PS over SIG BVC */</span><br><span> execute( TC_paging_ps_sig_bss() );</span><br><span> execute( TC_paging_ps_sig_lac() );</span><br><span> execute( TC_paging_ps_sig_lac_unknown() );</span><br><span>@@ -3412,7 +3419,6 @@</span><br><span> execute( TC_paging_ps_reject_sig_bvci_imsi() );</span><br><span> execute( TC_dummy_paging_ps_sig() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* PAGING-CS over PTP BVC */</span><br><span> execute( TC_paging_cs_ptp_bss() );</span><br><span> execute( TC_paging_cs_ptp_lac() );</span><br><span> execute( TC_paging_cs_ptp_lac_unknown() );</span><br><span>@@ -3421,7 +3427,6 @@</span><br><span> execute( TC_paging_cs_ptp_bvci() );</span><br><span> execute( TC_paging_cs_ptp_bvci_unknown() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* PAGING-CS over SIG BVC */</span><br><span> execute( TC_paging_cs_sig_bss() );</span><br><span> execute( TC_paging_cs_sig_lac() );</span><br><span> execute( TC_paging_cs_sig_lac_unknown() );</span><br><span>@@ -3430,7 +3435,6 @@</span><br><span> execute( TC_paging_cs_sig_bvci() );</span><br><span> execute( TC_paging_cs_sig_bvci_unknown() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* RAN Information Management */</span><br><span> execute( TC_rim_info_req() );</span><br><span> execute( TC_rim_info() );</span><br><span> execute( TC_rim_info_ack() );</span><br><span>@@ -3444,15 +3448,14 @@</span><br><span> execute( TC_fc_ms() );</span><br><span> execute( TC_ms_reg_enq() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Uplink STATUS */</span><br><span> execute( TC_status_sig_ul_tlli() );</span><br><span> execute( TC_status_sig_ul_tmsi() );</span><br><span> execute( TC_status_ptp_ul_tlli() );</span><br><span> execute( TC_status_ptp_ul_tmsi() );</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Downlink STATUS */</span><br><span> execute( TC_status_sig_dl_bvci() );</span><br><span> execute( TC_status_ptp_dl_bvci() );</span><br><span style="color: hsl(120, 100%, 40%);">+*/</span><br><span> }</span><br><span> </span><br><span> </span><br><span>diff --git a/gbproxy/osmo-gbproxy.fr.cfg b/gbproxy/osmo-gbproxy.fr.cfg</span><br><span>index 9595475..ba59f60 100644</span><br><span>--- a/gbproxy/osmo-gbproxy.fr.cfg</span><br><span>+++ b/gbproxy/osmo-gbproxy.fr.cfg</span><br><span>@@ -3,7 +3,17 @@</span><br><span> !!</span><br><span> !</span><br><span> log stderr</span><br><span style="color: hsl(120, 100%, 40%);">+ logging print category 1</span><br><span style="color: hsl(120, 100%, 40%);">+ logging print level 1</span><br><span style="color: hsl(120, 100%, 40%);">+ logging print file 1 last</span><br><span> logging level lns debug</span><br><span style="color: hsl(120, 100%, 40%);">+ logging level lbssgp debug</span><br><span style="color: hsl(120, 100%, 40%);">+ logging level gprs debug</span><br><span style="color: hsl(120, 100%, 40%);">+log gsmtap 127.0.0.1</span><br><span style="color: hsl(120, 100%, 40%);">+ logging filter all 1</span><br><span style="color: hsl(120, 100%, 40%);">+ logging level lns debug</span><br><span style="color: hsl(120, 100%, 40%);">+ logging level lbssgp debug</span><br><span style="color: hsl(120, 100%, 40%);">+ logging level gprs debug</span><br><span> line vty</span><br><span> no login</span><br><span> !</span><br><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index c6e22cc..b79aae4 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -768,7 +768,9 @@</span><br><span> function f_process_attach_accept(PDU_GMM_AttachAccept aa, integer ran_index := 0) runs on BSSGP_ConnHdlr {</span><br><span> /* mandatory IE */</span><br><span> var hexstring aa_plmn := f_RAI_to_plmn_hexstr(aa.routingAreaIdentification);</span><br><span style="color: hsl(0, 100%, 40%);">- if (not (g_pars.bssgp_cell_id[ran_index].ra_id.lai.mcc_mnc == aa_plmn)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ /* we cannot use ran_index here, as it would overflow the cell_id object, since ran_idx > NUM_GB</span><br><span style="color: hsl(120, 100%, 40%);">+ * indicates an Iu RAN connection. All cells are expected to run the same MCC/MNC anyway... */</span><br><span style="color: hsl(120, 100%, 40%);">+ if (not (g_pars.bssgp_cell_id[0].ra_id.lai.mcc_mnc == aa_plmn)) {</span><br><span> setverdict(fail, "mismatching PLMN in Attach Accept: " & hex2str(aa_plmn)</span><br><span> & "; expected " & hex2str(g_pars.bssgp_cell_id[ran_index].ra_id.lai.mcc_mnc));</span><br><span> mtc.stop;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22937">change 22937</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22937"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaae0015f5e7c7eabc426add91b5de1b63bf6d9f6 </div>
<div style="display:none"> Gerrit-Change-Number: 22937 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>