<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22931">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_bssgp: rename gprs_ns_config -> gprs_ns_update_config<br><br>Improve the naming of the function to match it's purpose.<br><br>Related: SYS#5354<br>Change-Id: Ib8e4ae734503fd6f6695d9d6767d809e1bf79d22<br>---<br>M src/gprs_bssgp_pcu.c<br>M src/gprs_bssgp_pcu.h<br>M src/pcu_l1_if.cpp<br>M tests/emu/pcu_emu.cpp<br>4 files changed, 8 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/31/22931/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c</span><br><span>index 7d793be..ce36c6b 100644</span><br><span>--- a/src/gprs_bssgp_pcu.c</span><br><span>+++ b/src/gprs_bssgp_pcu.c</span><br><span>@@ -1097,10 +1097,11 @@</span><br><span>        return 0;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,</span><br><span style="color: hsl(0, 100%, 40%);">-                   const struct osmo_sockaddr *local,</span><br><span style="color: hsl(0, 100%, 40%);">-              const struct osmo_sockaddr *remote,</span><br><span style="color: hsl(0, 100%, 40%);">-             uint16_t *nsvci, uint16_t valid)</span><br><span style="color: hsl(120, 100%, 40%);">+/* update the ns configuration if needed */</span><br><span style="color: hsl(120, 100%, 40%);">+int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,</span><br><span style="color: hsl(120, 100%, 40%);">+                         const struct osmo_sockaddr *local,</span><br><span style="color: hsl(120, 100%, 40%);">+                    const struct osmo_sockaddr *remote,</span><br><span style="color: hsl(120, 100%, 40%);">+                   uint16_t *nsvci, uint16_t valid)</span><br><span> {</span><br><span>      int rc = 0;</span><br><span>  if (!bts->nse) {</span><br><span>diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h</span><br><span>index 4b0e0aa..db77cbb 100644</span><br><span>--- a/src/gprs_bssgp_pcu.h</span><br><span>+++ b/src/gprs_bssgp_pcu.h</span><br><span>@@ -90,7 +90,7 @@</span><br><span>                 uint16_t mcc, uint16_t mnc, bool mnc_3_digits,</span><br><span>               uint16_t lac, uint16_t rac, uint16_t cell_id);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,</span><br><span style="color: hsl(120, 100%, 40%);">+int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,</span><br><span>                 const struct osmo_sockaddr *local,</span><br><span>                   const struct osmo_sockaddr *remote,</span><br><span>                  uint16_t *nsvci, uint16_t valid);</span><br><span>diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp</span><br><span>index 9873469..b6d6786 100644</span><br><span>--- a/src/pcu_l1_if.cpp</span><br><span>+++ b/src/pcu_l1_if.cpp</span><br><span>@@ -583,7 +583,7 @@</span><br><span>          return -EINVAL;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   return gprs_ns_config(bts, info_ind->nsei, local, remote, nsvci, valid);</span><br><span style="color: hsl(120, 100%, 40%);">+   return gprs_ns_update_config(bts, info_ind->nsei, local, remote, nsvci, valid);</span><br><span> }</span><br><span> </span><br><span> static int pcu_rx_info_ind(struct gprs_rlcmac_bts *bts, const struct gsm_pcu_if_info_ind *info_ind)</span><br><span>diff --git a/tests/emu/pcu_emu.cpp b/tests/emu/pcu_emu.cpp</span><br><span>index ef573a7..082f8ea 100644</span><br><span>--- a/tests/emu/pcu_emu.cpp</span><br><span>+++ b/tests/emu/pcu_emu.cpp</span><br><span>@@ -108,7 +108,7 @@</span><br><span>    remote.u.sin.sin_port = htons(sgsn_port);</span><br><span> </span><br><span>        pcu = gprs_bssgp_init(bts, 20, 20, 901, 99, false, 1, 0, 0);</span><br><span style="color: hsl(0, 100%, 40%);">-    gprs_ns_config(bts, nsei, &local, &remote, &nsvci, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+    gprs_ns_update_config(bts, nsei, &local, &remote, &nsvci, 1);</span><br><span> </span><br><span>        pcu->on_unblock_ack = bvci_unblocked;</span><br><span>     pcu->on_dl_unit_data = bssgp_data;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/22931">change 22931</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22931"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib8e4ae734503fd6f6695d9d6767d809e1bf79d22 </div>
<div style="display:none"> Gerrit-Change-Number: 22931 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>