<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22911">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_ns2_message: tx_status: move all cause dependent code into the switch/case<br><br>Change-Id: I8f1e0962c6f5f0c7287990bb7608d0cc9b86dfdb<br>---<br>M src/gb/gprs_ns2_message.c<br>1 file changed, 11 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/11/22911/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_message.c b/src/gb/gprs_ns2_message.c</span><br><span>index 7f52c4b..ddf7285 100644</span><br><span>--- a/src/gb/gprs_ns2_message.c</span><br><span>+++ b/src/gb/gprs_ns2_message.c</span><br><span>@@ -450,18 +450,18 @@</span><br><span> </span><br><span> msgb_tvlv_put(msg, NS_IE_CAUSE, 1, &cause);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Section 9.2.7.1: Static conditions for NS-VCI */</span><br><span style="color: hsl(0, 100%, 40%);">- if (cause == NS_CAUSE_NSVC_BLOCKED ||</span><br><span style="color: hsl(0, 100%, 40%);">- cause == NS_CAUSE_NSVC_UNKNOWN)</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_tvlv_put(msg, NS_IE_VCI, 2, (uint8_t *)&nsvci);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* Section 9.2.7.2: Static conditions for NS PDU */</span><br><span> switch (cause) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case NS_CAUSE_NSVC_BLOCKED:</span><br><span style="color: hsl(120, 100%, 40%);">+ case NS_CAUSE_NSVC_UNKNOWN:</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Section 9.2.7.1: Static conditions for NS-VCI */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_tvlv_put(msg, NS_IE_VCI, 2, (uint8_t *)&nsvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> case NS_CAUSE_SEM_INCORR_PDU:</span><br><span> case NS_CAUSE_PDU_INCOMP_PSTATE:</span><br><span> case NS_CAUSE_PROTO_ERR_UNSPEC:</span><br><span> case NS_CAUSE_INVAL_ESSENT_IE:</span><br><span> case NS_CAUSE_MISSING_ESSENT_IE:</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Section 9.2.7.2: Static conditions for NS PDU */</span><br><span> /* ensure the PDU doesn't exceed the MTU */</span><br><span> orig_len = msgb_l2len(orig_msg);</span><br><span> max_orig_len = msgb_length(msg) + TVLV_GROSS_LEN(orig_len);</span><br><span>@@ -469,14 +469,15 @@</span><br><span> orig_len -= max_orig_len - nsvc->bind->mtu;</span><br><span> msgb_tvlv_put(msg, NS_IE_PDU, orig_len, orig_msg->l2h);</span><br><span> break;</span><br><span style="color: hsl(120, 100%, 40%);">+ case NS_CAUSE_BVCI_UNKNOWN:</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Section 9.2.7.3: Static conditions for BVCI */</span><br><span style="color: hsl(120, 100%, 40%);">+ msgb_tvlv_put(msg, NS_IE_VCI, 2, (uint8_t *)&bvci);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> default:</span><br><span> break;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* Section 9.2.7.3: Static conditions for BVCI */</span><br><span style="color: hsl(0, 100%, 40%);">- if (cause == NS_CAUSE_BVCI_UNKNOWN)</span><br><span style="color: hsl(0, 100%, 40%);">- msgb_tvlv_put(msg, NS_IE_VCI, 2, (uint8_t *)&bvci);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> return ns_vc_tx(nsvc, msg);</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22911">change 22911</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22911"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8f1e0962c6f5f0c7287990bb7608d0cc9b86dfdb </div>
<div style="display:none"> Gerrit-Change-Number: 22911 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>