<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22892">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">GSMTAP: fix wrong naming of per-BTS SAPI commands<br><br>Change-Id: Ieb2d74475e4338e9dd5f3962cf14a0448de253f8<br>---<br>M src/common/vty.c<br>1 file changed, 10 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/vty.c b/src/common/vty.c</span><br><span>index 84e3968..976ccfa 100644</span><br><span>--- a/src/common/vty.c</span><br><span>+++ b/src/common/vty.c</span><br><span>@@ -1826,7 +1826,7 @@</span><br><span> "logical channel commands\n" \</span><br><span> "logical channel number\n"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN(cfg_trx_gsmtap_sapi_all, cfg_trx_gsmtap_sapi_all_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_bts_gsmtap_sapi_all, cfg_bts_gsmtap_sapi_all_cmd,</span><br><span> "gsmtap-sapi (enable-all|disable-all)",</span><br><span> "Enable/disable sending of UL/DL messages over GSMTAP\n"</span><br><span> "Enable all kinds of messages (all SAPI)\n"</span><br><span>@@ -1843,7 +1843,7 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN(cfg_trx_gsmtap_sapi, cfg_trx_gsmtap_sapi_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_bts_gsmtap_sapi, cfg_bts_gsmtap_sapi_cmd,</span><br><span> "HIDDEN", "HIDDEN")</span><br><span> {</span><br><span> int sapi;</span><br><span>@@ -1859,7 +1859,7 @@</span><br><span> return CMD_SUCCESS;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-DEFUN(cfg_trx_no_gsmtap_sapi, cfg_trx_no_gsmtap_sapi_cmd,</span><br><span style="color: hsl(120, 100%, 40%);">+DEFUN(cfg_trx_no_gsmtap_sapi, cfg_bts_no_gsmtap_sapi_cmd,</span><br><span> "HIDDEN", "HIDDEN")</span><br><span> {</span><br><span> int sapi;</span><br><span>@@ -2165,17 +2165,17 @@</span><br><span> </span><br><span> int bts_vty_init(void *ctx)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- cfg_trx_gsmtap_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_bts_gsmtap_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span> "gsmtap-sapi (",</span><br><span> "|",")", VTY_DO_LOWER);</span><br><span style="color: hsl(0, 100%, 40%);">- cfg_trx_gsmtap_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_bts_gsmtap_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span> "Enable sending of UL/DL messages over GSMTAP\n",</span><br><span> "\n", "", 0);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- cfg_trx_no_gsmtap_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_bts_no_gsmtap_sapi_cmd.string = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span> "no gsmtap-sapi (",</span><br><span> "|",")", VTY_DO_LOWER);</span><br><span style="color: hsl(0, 100%, 40%);">- cfg_trx_no_gsmtap_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span style="color: hsl(120, 100%, 40%);">+ cfg_bts_no_gsmtap_sapi_cmd.doc = vty_cmd_string_from_valstr(ctx, gsmtap_sapi_names,</span><br><span> NO_STR "Disable sending of UL/DL messages over GSMTAP\n",</span><br><span> "\n", "", 0);</span><br><span> </span><br><span>@@ -2233,9 +2233,9 @@</span><br><span> install_element(BTS_NODE, &cfg_bts_smscb_tgt_qlen_cmd);</span><br><span> install_element(BTS_NODE, &cfg_bts_smscb_qhyst_cmd);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- install_element(BTS_NODE, &cfg_trx_gsmtap_sapi_all_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">- install_element(BTS_NODE, &cfg_trx_gsmtap_sapi_cmd);</span><br><span style="color: hsl(0, 100%, 40%);">- install_element(BTS_NODE, &cfg_trx_no_gsmtap_sapi_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(BTS_NODE, &cfg_bts_gsmtap_sapi_all_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(BTS_NODE, &cfg_bts_gsmtap_sapi_cmd);</span><br><span style="color: hsl(120, 100%, 40%);">+ install_element(BTS_NODE, &cfg_bts_no_gsmtap_sapi_cmd);</span><br><span> </span><br><span> /* add and link to TRX config node */</span><br><span> install_element(BTS_NODE, &cfg_bts_trx_cmd);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22892">change 22892</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22892"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieb2d74475e4338e9dd5f3962cf14a0448de253f8 </div>
<div style="display:none"> Gerrit-Change-Number: 22892 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>