<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22884">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn: Fix f_process_attach_accept on ran_index != 0<br><br>Change-Id: I7d859fd710dba96eb9b46c428243281183e1be12<br>---<br>M sgsn/SGSN_Tests.ttcn<br>1 file changed, 8 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn</span><br><span>index 4c0a8ab..4e35144 100644</span><br><span>--- a/sgsn/SGSN_Tests.ttcn</span><br><span>+++ b/sgsn/SGSN_Tests.ttcn</span><br><span>@@ -765,12 +765,12 @@</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-function f_process_attach_accept(PDU_GMM_AttachAccept aa) runs on BSSGP_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+function f_process_attach_accept(PDU_GMM_AttachAccept aa, integer ran_index := 0) runs on BSSGP_ConnHdlr {</span><br><span>     /* mandatory IE */</span><br><span>   var hexstring aa_plmn := f_RAI_to_plmn_hexstr(aa.routingAreaIdentification);</span><br><span style="color: hsl(0, 100%, 40%);">-    if (not (g_pars.bssgp_cell_id[0].ra_id.lai.mcc_mnc == aa_plmn)) {</span><br><span style="color: hsl(120, 100%, 40%);">+     if (not (g_pars.bssgp_cell_id[ran_index].ra_id.lai.mcc_mnc == aa_plmn)) {</span><br><span>              setverdict(fail, "mismatching PLMN in Attach Accept: " & hex2str(aa_plmn)</span><br><span style="color: hsl(0, 100%, 40%);">-                                  & "; expected " & hex2str(g_pars.bssgp_cell_id[0].ra_id.lai.mcc_mnc));</span><br><span style="color: hsl(120, 100%, 40%);">+                              & "; expected " & hex2str(g_pars.bssgp_cell_id[ran_index].ra_id.lai.mcc_mnc));</span><br><span>            mtc.stop;</span><br><span>  }</span><br><span>    g_pars.ra := aa.routingAreaIdentification;</span><br><span>@@ -779,7 +779,8 @@</span><br><span>                     setverdict(fail, "unexpected P-TMSI allocation");</span><br><span>                  mtc.stop;</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               f_upd_ptmsi_and_tlli(aa.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets);</span><br><span style="color: hsl(120, 100%, 40%);">+               f_upd_ptmsi_and_tlli(aa.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets,</span><br><span style="color: hsl(120, 100%, 40%);">+                                     ran_index);</span><br><span>     }</span><br><span>    if (ispresent(aa.msIdentity)) {</span><br><span>              setverdict(fail, "unexpected TMSI allocation in non-combined attach");</span><br><span>@@ -802,7 +803,8 @@</span><br><span>                       setverdict(fail, "unexpected P-TMSI allocation");</span><br><span>                  mtc.stop;</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets, ran_index);</span><br><span style="color: hsl(120, 100%, 40%);">+            f_upd_ptmsi_and_tlli(ra.allocatedPTMSI.mobileIdentityLV.mobileIdentityV.oddEvenInd_identity.tmsi_ptmsi.octets,</span><br><span style="color: hsl(120, 100%, 40%);">+                                     ran_index);</span><br><span>     }</span><br><span>    if (ispresent(ra.msIdentity)) {</span><br><span>              setverdict(fail, "unexpected TMSI allocation in non-combined attach");</span><br><span>@@ -860,7 +862,7 @@</span><br><span>       f_gmm_gsup_lu_isd();</span><br><span> </span><br><span>     l3_mt := f_receive_l3(tr_GMM_ATTACH_ACCEPT('001'B, ?, ?), ran_index);</span><br><span style="color: hsl(0, 100%, 40%);">-   f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept);</span><br><span style="color: hsl(120, 100%, 40%);">+     f_process_attach_accept(l3_mt.msgs.gprs_mm.attachAccept, ran_index);</span><br><span> </span><br><span>     /* FIXME: Extract P-TMSI, if any. Only send Complete if necessary */</span><br><span>         f_send_l3(ts_GMM_ATTACH_COMPL, ran_index);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22884">change 22884</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22884"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7d859fd710dba96eb9b46c428243281183e1be12 </div>
<div style="display:none"> Gerrit-Change-Number: 22884 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>