<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22860">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: fix repeated_dl_facch_active_decision()<br><br>The function checks meas_res->rxqual_sub against the lower threshold<br>value in order to decide when to turn FACCH repetition off. This is not<br>correct. It should compare against rxqual instead.<br><br>Change-Id: Id4ab101d52f419583c4f4c8a6cf69af6c9097d25<br>Related: SYS#5114<br>---<br>M src/common/l1sap.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 1542c8a..b6970f4 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1025,7 +1025,7 @@</span><br><span> </span><br><span>        if (rxqual >= upper)</span><br><span>              lchan->repeated_dl_facch_active = true;</span><br><span style="color: hsl(0, 100%, 40%);">-      else if (meas_res->rxqual_sub <= lower)</span><br><span style="color: hsl(120, 100%, 40%);">+ else if (rxqual <= lower)</span><br><span>                 lchan->repeated_dl_facch_active = false;</span><br><span> </span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22860">change 22860</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22860"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id4ab101d52f419583c4f4c8a6cf69af6c9097d25 </div>
<div style="display:none"> Gerrit-Change-Number: 22860 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>