<p>daniel has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22889">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bssgp_bvc_fsm: Consistent naming<br><br>bssgp_bvc_get_features_* are fsm "methods" and the name should indicate<br>that just lika all other function names in bssgp_bvc_fsm.h<br><br>Change-Id: I30fbbe36cdabf9635eaf4dfb1e93c8ce0f667b39<br>---<br>M include/osmocom/gprs/bssgp_bvc_fsm.h<br>M src/gb/bssgp_bvc_fsm.c<br>M src/gb/libosmogb.map<br>3 files changed, 9 insertions(+), 9 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/89/22889/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gprs/bssgp_bvc_fsm.h b/include/osmocom/gprs/bssgp_bvc_fsm.h</span><br><span>index 824cdec..446dda8 100644</span><br><span>--- a/include/osmocom/gprs/bssgp_bvc_fsm.h</span><br><span>+++ b/include/osmocom/gprs/bssgp_bvc_fsm.h</span><br><span>@@ -61,9 +61,9 @@</span><br><span> </span><br><span> uint8_t bssgp_bvc_fsm_get_block_cause(struct osmo_fsm_inst *fi);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-uint32_t bssgp_bvc_get_features_advertised(struct osmo_fsm_inst *fi);</span><br><span style="color: hsl(0, 100%, 40%);">-uint32_t bssgp_bvc_get_features_received(struct osmo_fsm_inst *fi);</span><br><span style="color: hsl(0, 100%, 40%);">-uint32_t bssgp_bvc_get_features_negotiated(struct osmo_fsm_inst *fi);</span><br><span style="color: hsl(120, 100%, 40%);">+uint32_t bssgp_bvc_fsm_get_features_advertised(struct osmo_fsm_inst *fi);</span><br><span style="color: hsl(120, 100%, 40%);">+uint32_t bssgp_bvc_fsm_get_features_received(struct osmo_fsm_inst *fi);</span><br><span style="color: hsl(120, 100%, 40%);">+uint32_t bssgp_bvc_fsm_get_features_negotiated(struct osmo_fsm_inst *fi);</span><br><span> </span><br><span> void bssgp_bvc_fsm_set_max_pdu_len(struct osmo_fsm_inst *fi, uint16_t max_pdu_len);</span><br><span> uint16_t bssgp_bvc_fsm_get_max_pdu_len(const struct osmo_fsm_inst *fi);</span><br><span>\ No newline at end of file</span><br><span>diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c</span><br><span>index a035938..8d284d1 100644</span><br><span>--- a/src/gb/bssgp_bvc_fsm.c</span><br><span>+++ b/src/gb/bssgp_bvc_fsm.c</span><br><span>@@ -794,7 +794,7 @@</span><br><span> }</span><br><span> </span><br><span> /*! Return the advertised features / extended features. */</span><br><span style="color: hsl(0, 100%, 40%);">-uint32_t bssgp_bvc_get_features_advertised(struct osmo_fsm_inst *fi)</span><br><span style="color: hsl(120, 100%, 40%);">+uint32_t bssgp_bvc_fsm_get_features_advertised(struct osmo_fsm_inst *fi)</span><br><span> {</span><br><span>         struct bvc_fsm_priv *bfp = fi->priv;</span><br><span> </span><br><span>@@ -803,7 +803,7 @@</span><br><span> }</span><br><span> </span><br><span> /*! Return the received features / extended features. */</span><br><span style="color: hsl(0, 100%, 40%);">-uint32_t bssgp_bvc_get_features_received(struct osmo_fsm_inst *fi)</span><br><span style="color: hsl(120, 100%, 40%);">+uint32_t bssgp_bvc_fsm_get_features_received(struct osmo_fsm_inst *fi)</span><br><span> {</span><br><span>        struct bvc_fsm_priv *bfp = fi->priv;</span><br><span> </span><br><span>@@ -812,7 +812,7 @@</span><br><span> }</span><br><span> </span><br><span> /*! Return the negotiated features / extended features. */</span><br><span style="color: hsl(0, 100%, 40%);">-uint32_t bssgp_bvc_get_features_negotiated(struct osmo_fsm_inst *fi)</span><br><span style="color: hsl(120, 100%, 40%);">+uint32_t bssgp_bvc_fsm_get_features_negotiated(struct osmo_fsm_inst *fi)</span><br><span> {</span><br><span>  struct bvc_fsm_priv *bfp = fi->priv;</span><br><span> </span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index 2327815..699ed1b 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -93,9 +93,9 @@</span><br><span> bssgp_bvc_fsm_set_ops;</span><br><span> bssgp_bvc_fsm_is_unblocked;</span><br><span> bssgp_bvc_fsm_get_block_cause;</span><br><span style="color: hsl(0, 100%, 40%);">-bssgp_bvc_get_features_advertised;</span><br><span style="color: hsl(0, 100%, 40%);">-bssgp_bvc_get_features_received;</span><br><span style="color: hsl(0, 100%, 40%);">-bssgp_bvc_get_features_negotiated;</span><br><span style="color: hsl(120, 100%, 40%);">+bssgp_bvc_fsm_get_features_advertised;</span><br><span style="color: hsl(120, 100%, 40%);">+bssgp_bvc_fsm_get_features_received;</span><br><span style="color: hsl(120, 100%, 40%);">+bssgp_bvc_fsm_get_features_negotiated;</span><br><span> bssgp_bvc_fsm_set_max_pdu_len;</span><br><span> bssgp_bvc_fsm_get_max_pdu_len;</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22889">change 22889</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22889"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I30fbbe36cdabf9635eaf4dfb1e93c8ce0f667b39 </div>
<div style="display:none"> Gerrit-Change-Number: 22889 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>