<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868">View Change</a></p><p>9 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">date</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">data</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@10">Patch Set #1, Line 10:</a> <code style="font-family:monospace,monospace"> use </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">used</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@12">Patch Set #1, Line 12:</a> <code style="font-family:monospace,monospace">use</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">uses</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1//COMMIT_MSG@15">Patch Set #1, Line 15:</a> <code style="font-family:monospace,monospace">support</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">supports</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/include/osmocom/gprs/gprs_ns2.h">File include/osmocom/gprs/gprs_ns2.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/include/osmocom/gprs/gprs_ns2.h@218">Patch Set #1, Line 218:</a> <code style="font-family:monospace,monospace">void gprs_ns2_ip_bind_set_sns_weight(struct gprs_ns2_vc_bind *bind,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Also add it in libosmogb.map</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_internal.h">File src/gb/gprs_ns2_internal.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_internal.h@261">Patch Set #1, Line 261:</a> <code style="font-family:monospace,monospace">       uint8_t sns_signalling_weight;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">could be sns_sig_weight to stay consistent with the other variable names (ipx_elems->sig_weight)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_internal.h@360">Patch Set #1, Line 360:</a> <code style="font-family:monospace,monospace">void ns2_update_weights(struct gprs_ns2_vc_bind *bind);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ns2_sns_update_weights or is this not SNS-specific?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_vty.c">File src/gb/gprs_ns2_vty.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_vty.c@69">Patch Set #1, Line 69:</a> <code style="font-family:monospace,monospace">      uint8_t ip_sns_signalling_weight;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">*_sig_weight</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/22868/1/src/gb/gprs_ns2_vty.c@335">Patch Set #1, Line 335:</a> <code style="font-family:monospace,monospace">            vty_out(vty, "   ip-sns signalling-weight %u data-weight %u%s",</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">sig-weight here as well? For the vty commands I'm not so sure.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22868">change 22868</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22868"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5133e4229377d44772a9af28628a2bc420fea34b </div>
<div style="display:none"> Gerrit-Change-Number: 22868 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 12 Feb 2021 02:16:27 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>