<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22880">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm: Fix bitfield order in dtap_header<br><br>This bitfield was added later and all osmocom code still uses the old<br>field contain 1 byte "link_id". There's only one known user of the new<br>bitfield which only uses it to log the SAPI name in osmocom, so no<br>logical breakage is expected with this change (other than fixing a log<br>line).<br><br>While at it, fix a typo in comment describing related enum.<br><br>Related: SYS#4909<br>Fixes: 392f607f2d42eb2839ccfc4c1b9e2c7cfaf3bcc2<br>Change-Id: I84866f03ee642aa7f1da273c93a16a38234cfa67<br>---<br>M include/osmocom/gsm/protocol/gsm_08_08.h<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/80/22880/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>index fe7776b..7ef7a29 100644</span><br><span>--- a/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>+++ b/include/osmocom/gsm/protocol/gsm_08_08.h</span><br><span>@@ -49,12 +49,12 @@</span><br><span>            uint8_t link_id;  /* Backward compatibility */</span><br><span>               struct {</span><br><span> #if OSMO_IS_LITTLE_ENDIAN</span><br><span style="color: hsl(0, 100%, 40%);">-                   uint8_t dlci_cc:2,</span><br><span style="color: hsl(120, 100%, 40%);">+                    uint8_t dlci_sapi:3, /* enum gsm0406_dlci_sapi */</span><br><span>                    dlci_spare:3,</span><br><span style="color: hsl(0, 100%, 40%);">-                   dlci_sapi:3; /* enum gsm0406_dlc_sapi */</span><br><span style="color: hsl(120, 100%, 40%);">+                      dlci_cc:2;</span><br><span> #elif OSMO_IS_BIG_ENDIAN</span><br><span> /* auto-generated from the little endian part above (libosmocore/contrib/struct_endianess.py) */</span><br><span style="color: hsl(0, 100%, 40%);">-                      uint8_t dlci_sapi:3, dlci_spare:3, dlci_cc:2;</span><br><span style="color: hsl(120, 100%, 40%);">+                 uint8_t dlci_cc:2, dlci_spare:3, dlci_sapi:3;</span><br><span> #endif</span><br><span>              };</span><br><span>   };</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22880">change 22880</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22880"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I84866f03ee642aa7f1da273c93a16a38234cfa67 </div>
<div style="display:none"> Gerrit-Change-Number: 22880 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>