<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gbproxy: Fix TC_dl_unitdata test failure introduced by 6ee0126971<br><br>This commit used a send template (ts) to match a received BSSGP PDU which<br>doesn't work due to some differences in the length field.<br>Use tr_BSSGP_IMSI again and change the template restrictions so it<br>compiles.<br><br>Fixes: 6ee0126971c83fd60658761263af559a482f13d9<br>Change-Id: I85676e96f8d32a9d2c7deadc1d66707b6b8697d0<br>---<br>M gbproxy/GBProxy_Tests.ttcn<br>M library/Osmocom_Gb_Types.ttcn<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn</span><br><span>index af9646c..e12d69f 100644</span><br><span>--- a/gbproxy/GBProxy_Tests.ttcn</span><br><span>+++ b/gbproxy/GBProxy_Tests.ttcn</span><br><span>@@ -1105,7 +1105,7 @@</span><br><span>                    ts_BSSGP_DL_UD(g_pars.tlli, payload, omit, ts_BSSGP_IMSI(g_pars.imsi));</span><br><span>              /* we cannot use pdu_tx as there are some subtle differences in the length field :/ */</span><br><span>               var template (present) PDU_BSSGP pdu_rx :=</span><br><span style="color: hsl(0, 100%, 40%);">-                      tr_BSSGP_DL_UD(g_pars.tlli, payload, ts_BSSGP_IMSI(g_pars.imsi));</span><br><span style="color: hsl(120, 100%, 40%);">+                     tr_BSSGP_DL_UD(g_pars.tlli, payload, tr_BSSGP_IMSI(g_pars.imsi));</span><br><span> </span><br><span>                log("DL-UNITDATA(payload_size=", i);</span><br><span>               f_sgsn2pcu(pdu_tx, pdu_rx);</span><br><span>diff --git a/library/Osmocom_Gb_Types.ttcn b/library/Osmocom_Gb_Types.ttcn</span><br><span>index 687a073..76988b5 100644</span><br><span>--- a/library/Osmocom_Gb_Types.ttcn</span><br><span>+++ b/library/Osmocom_Gb_Types.ttcn</span><br><span>@@ -1815,7 +1815,7 @@</span><br><span>                 }</span><br><span>    }</span><br><span>    template (present) PDU_BSSGP tr_BSSGP_DL_UD(template (present) GprsTlli tlli, template (present) octetstring pdu,</span><br><span style="color: hsl(0, 100%, 40%);">-                                         template (omit) IMSI_BSSGP imsi := omit) := {</span><br><span style="color: hsl(120, 100%, 40%);">+                                         template IMSI_BSSGP imsi := omit) := {</span><br><span>             pDU_BSSGP_DL_UNITDATA := {</span><br><span>                   bssgpPduType := '00'O,</span><br><span>                       tLLI_current := tlli,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845">change 22845</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/22845"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I85676e96f8d32a9d2c7deadc1d66707b6b8697d0 </div>
<div style="display:none"> Gerrit-Change-Number: 22845 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>