<p>osmith <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/docker-playground/+/22818">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  osmith: Looks good to me, approved; Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">debian-stretch-titan: update deps on change<br><br>After the initial clone of osmo-ttcn3-hacks and deps, let docker<br>download deps/Makefile to invalidate the cache if the file changed.<br><br>Run "git pull" and "make deps" afterwards, but only if the Makefile is<br>different. The "if" saves time in the initial build of the image, it<br>avoids the "git fetch" on every dependency repository during "make deps".<br><br>Related: OS#5017<br>Change-Id: I56673312cfb23375d67900016aaac1931f677275<br>---<br>M debian-stretch-titan/Dockerfile<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/debian-stretch-titan/Dockerfile b/debian-stretch-titan/Dockerfile</span><br><span>index 0f4f17e..39ff76f 100644</span><br><span>--- a/debian-stretch-titan/Dockerfile</span><br><span>+++ b/debian-stretch-titan/Dockerfile</span><br><span>@@ -52,6 +52,12 @@</span><br><span> RUN       git config --global user.email docker@dock.er && \</span><br><span>   git config --global user.name "Dock Er"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-# clone osmo-ttcn3-hacks and deps</span><br><span style="color: hsl(120, 100%, 40%);">+# clone osmo-ttcn3-hacks and deps, invalidate cache if deps change (OS#5017)</span><br><span> RUN     git clone git://git.osmocom.org/osmo-ttcn3-hacks.git && \</span><br><span>    make -C /osmo-ttcn3-hacks deps</span><br><span style="color: hsl(120, 100%, 40%);">+ADD     https://git.osmocom.org/osmo-ttcn3-hacks/plain/deps/Makefile /tmp/deps-Makefile</span><br><span style="color: hsl(120, 100%, 40%);">+RUN    if ! diff -q /tmp/deps-Makefile /osmo-ttcn3-hacks/deps/Makefile; then \</span><br><span style="color: hsl(120, 100%, 40%);">+               cd /osmo-ttcn3-hacks && \</span><br><span style="color: hsl(120, 100%, 40%);">+             git pull && \</span><br><span style="color: hsl(120, 100%, 40%);">+         make deps; \</span><br><span style="color: hsl(120, 100%, 40%);">+  fi</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/22818">change 22818</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/22818"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I56673312cfb23375d67900016aaac1931f677275 </div>
<div style="display:none"> Gerrit-Change-Number: 22818 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>