<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22850">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2_fr: Fix heap-use-after-free in error recovery path<br><br><0026> gprs_ns2_fr.c:515 BIND(hdlcnet1) Can not create AF_PACKET socket. Are you root or have CAP_NET_RAW?<br>=================================================================<br>==3872359==ERROR: AddressSanitizer: heap-use-after-free on address 0x6130000030c0 at pc 0x7fef120aa92e bp 0x7ffebf6b5c20 sp 0x7ffebf6b5c18<br>READ of size 8 at 0x6130000030c0 thread T0<br>    #0 0x7fef120aa92d in osmo_fr_link_free (/usr/local/lib/libosmogb.so.11+0x16992d)<br>    #1 0x7fef1205105a in free_bind (/usr/local/lib/libosmogb.so.11+0x11005a)<br><br>Change-Id: I23c0f1697edd5734085fa18b0a2f253c0f206c53<br>---<br>M src/gb/gprs_ns2_fr.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/22850/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c</span><br><span>index 2df5986..7e6db2a 100644</span><br><span>--- a/src/gb/gprs_ns2_fr.c</span><br><span>+++ b/src/gb/gprs_ns2_fr.c</span><br><span>@@ -863,6 +863,7 @@</span><br><span>   close(priv->backlog.ofd.fd);</span><br><span> err_fr:</span><br><span>   osmo_fr_link_free(fr_link);</span><br><span style="color: hsl(120, 100%, 40%);">+   priv->link = NULL;</span><br><span> err_bind:</span><br><span>   gprs_ns2_free_bind(bind);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22850">change 22850</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22850"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I23c0f1697edd5734085fa18b0a2f253c0f206c53 </div>
<div style="display:none"> Gerrit-Change-Number: 22850 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>