<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/22862">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: be sure that UL-SACCH repetition is turned off<br><br>At the beginning of repeated_ul_sacch_active_decision() The UL-SACCH<br>repetition capability is tested. If no UL-SACCH repetition is enabled<br>the function exits. However, we should also make sure that the struct<br>member that enabled UL-SACCH repetition on the lower level is set to<br>false as well. Normally that should be the case because it was never<br>set to true before, but it is better to be sure.<br><br>Change-Id: I76a841514eb955b93f2114470b2c80402cf6883c<br>Related: SYS#5114<br>---<br>M src/common/l1sap.c<br>1 file changed, 7 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/62/22862/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 3de76ab..97dd661 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -1427,8 +1427,14 @@</span><br><span>      uint16_t upper = 0;</span><br><span>  uint16_t lower = 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!lchan->repeated_acch_capability.ul_sacch)</span><br><span style="color: hsl(120, 100%, 40%);">+     /* This is an optimization so that we exit as quickly as possible if</span><br><span style="color: hsl(120, 100%, 40%);">+   * there are no uplink SACCH repetition capabilities present.</span><br><span style="color: hsl(120, 100%, 40%);">+  * However If the repeated UL-SACCH capabilities vanish for whatever</span><br><span style="color: hsl(120, 100%, 40%);">+   * reason, we must be sure that UL-SACCH repetition is disabled. */</span><br><span style="color: hsl(120, 100%, 40%);">+   if (!lchan->repeated_acch_capability.ul_sacch) {</span><br><span style="color: hsl(120, 100%, 40%);">+           lchan->repeated_ul_sacch_active = false;</span><br><span>          return;</span><br><span style="color: hsl(120, 100%, 40%);">+       }</span><br><span> </span><br><span>        /* Threshold disabled (repetition is always on) */</span><br><span>   if (lchan->repeated_acch_capability.rxqual == 0) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/22862">change 22862</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/22862"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I76a841514eb955b93f2114470b2c80402cf6883c </div>
<div style="display:none"> Gerrit-Change-Number: 22862 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>