<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/22849">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ns2_fr: Fix null pointer deref in error path<br><br>The followign happens if osmo-gbproxy is started without CAP_NET_RAW:<br><br><0026> gprs_ns2_fr.c:515 BIND(hdlcnet1) Can not create AF_PACKET socket. Are you root or have CAP_NET_RAW?<br>gprs_ns2_fr.c:176:2: runtime error: member access within null pointer of type 'struct msgb' AddressSanitizer:DEADLYSIGNAL<br><br>the second line is free_bind() iterating overr the backlog while<br>destroying the not-yet-fully-initialized bind.<br><br>Let's make sure the backlog llist_head is always initialized properly.<br><br>Change-Id: I4d2fa50955c5897cd469fee68d4ddc65a9f5688f<br>---<br>M src/gb/gprs_ns2_fr.c<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/49/22849/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gb/gprs_ns2_fr.c b/src/gb/gprs_ns2_fr.c</span><br><span>index 93b7759..2df5986 100644</span><br><span>--- a/src/gb/gprs_ns2_fr.c</span><br><span>+++ b/src/gb/gprs_ns2_fr.c</span><br><span>@@ -807,6 +807,7 @@</span><br><span>               goto err_bind;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ INIT_LLIST_HEAD(&priv->backlog.list);</span><br><span>         OSMO_STRLCPY_ARRAY(priv->netif, netif);</span><br><span> </span><br><span>       /* FIXME: move fd handling into socket.c */</span><br><span>@@ -836,7 +837,6 @@</span><br><span>    rc = open_socket(priv->ifindex, bind);</span><br><span>    if (rc < 0)</span><br><span>               goto err_fr;</span><br><span style="color: hsl(0, 100%, 40%);">-    INIT_LLIST_HEAD(&priv->backlog.list);</span><br><span>         priv->backlog.retry_us = 2500; /* start with some non-zero value; this corrsponds to 496 bytes */</span><br><span>         osmo_timer_setup(&priv->backlog.timer, fr_backlog_timer_cb, bind);</span><br><span>    osmo_fd_setup(&priv->backlog.ofd, rc, OSMO_FD_READ, fr_netif_ofd_cb, bind, 0);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/22849">change 22849</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/22849"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4d2fa50955c5897cd469fee68d4ddc65a9f5688f </div>
<div style="display:none"> Gerrit-Change-Number: 22849 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>